feat(lsp): improve actions, navigation, and position handling - #2837
Merged
Conversation
bajrangCoder
commented
Aug 30, 2026
Member
- advertise code action resolve support
- clamp LSP positions beyond document bounds
- support LocationLink and multiple navigation results
- add LSP operations to the selection menu
- fix navigation scrolling after switching files
- use shared position and location normalization helpers
- advertise code action resolve support - clamp LSP positions beyond document bounds - support LocationLink and multiple navigation results - add LSP operations to the selection menu - fix navigation scrolling after switching files - use shared position and location normalization helpers
Contributor
Greptile SummaryThe PR expands LSP navigation and touch-menu actions while centralizing safe position and location normalization.
Confidence Score: 5/5The PR appears safe to merge with no concrete changed-code failures identified. The navigation, position normalization, workspace-edit mapping, selection-menu capability checks, and delayed-scroll cancellation paths are internally consistent with the repository contracts examined. Important Files Changed
Sequence DiagramsequenceDiagram
participant U as User
participant C as LSP command
participant S as Language server
participant N as Location normalizer
participant P as References panel
participant E as Editor manager
U->>C: Invoke navigation action
C->>S: textDocument definition-family request
S-->>C: Location, Location[], or LocationLink[]
C->>N: Normalize and deduplicate results
alt One location
N->>E: Open file and reveal range
else Multiple locations
N->>P: Display normalized results
U->>P: Select result
P->>E: Open file and reveal range
end
Reviews (1): Last reviewed commit: "feat(lsp): improve actions, navigation, ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.