fix encoding for request body#56
Merged
ibalosh merged 1 commit intoActiveCampaign:mainfrom Mar 6, 2023
Merged
Conversation
Contributor
|
Thank you @pheyken will see to check this out today |
ibalosh
approved these changes
Mar 6, 2023
Contributor
|
thank you @pheyken for reproducing and creating integration test for the fix too! |
Contributor
|
Fix is applied to main, I am waiting for maven server to release it, they seem to have some issues, should be out in couple of hours |
Contributor
|
released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you very much for fixing #35 by moving to the Apache HTTP client!
While testing the new version, I noticed that special characters were not encoded correctly when sending an email.
Using setEntity without a ContentType defaults to text/plain with ISO 8859-1, explicitly setting it to application/json solves the encoding issue.