Skip to content

Added headless state notifications#1249

Merged
Naatan merged 7 commits intomasterfrom
pr/176809621
Feb 23, 2021
Merged

Added headless state notifications#1249
Naatan merged 7 commits intomasterfrom
pr/176809621

Conversation

@Naatan
Copy link
Copy Markdown
Contributor

@Naatan Naatan commented Feb 9, 2021

https://www.pivotaltracker.com/story/show/176809621

Message is a placeholder, product and Luke should review:

image

@Naatan Naatan requested review from daved, flukeout and rawktron February 9, 2021 22:10
daved
daved previously approved these changes Feb 9, 2021
Comment thread locale/en-us.yaml
Type [ACTIONABLE]`state branch switch <NAME>`[/RESET] to switch to a different branch.
err_set_default_branch:
other: Could not update project field with branch, please manually set the `branch={{.V0}}` query parameter on the project field in your activestate.yaml. No newline at end of file
other: Could not update project field with branch, please manually set the `branch={{.V0}}` query parameter on the project field in your activestate.yaml.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
other: Could not update project field with branch, please manually set the `branch={{.V0}}` query parameter on the project field in your activestate.yaml.
other: Could not update project field with branch. Please manually set the `branch={{.V0}}` query parameter on the project field in your activestate.yaml.

@daved
Copy link
Copy Markdown
Contributor

daved commented Feb 9, 2021

This PR uses the term "detached", but the URL uses "headless". If these two terms are surely the same, I suggest using only one of them across user-facing content.

@flukeout
Copy link
Copy Markdown

Will take a look in the morning tomorrow!

@Naatan
Copy link
Copy Markdown
Contributor Author

Naatan commented Feb 10, 2021

This PR uses the term "detached", but the URL uses "headless". If these two terms are surely the same, I suggest using only one of them across user-facing content.

Fwiw this is on purpose since so far the internal lingo has been "headless" and to my knowledge we've had no external lingo. Imo "detached" makes more sense for users. Agree it would be nice if internal and external lingo matched.

@flukeout
Copy link
Copy Markdown

flukeout commented Feb 11, 2021

Here's a take on the copy, I'll get Pete to take a look at it as well. I think we should indicate what a detached state is & indicate why creating a project is useful. Let me know your thoughts, I'll run through it with @rawktron in our stand as well.

Detached State
--------------
Your changes are local and will not be saved the cloud. Visit...
· Visit https://platform.activestate.com/commit/ebb055557-45648-45648-45648 
...to create a project at this point and create a reusable runtime.

For more information, including how to attach to an existing project, visit...
· https://docs.activestate.com/platform/state/advanced-topics/headless

Not particularly hot on saved to the cloud, if you have any ideas to convey that it would be helpful, I'll think some more too.

cc @Naatan

@rawktron
Copy link
Copy Markdown

Here's a take on the copy, I'll get Pete to take a look at it as well. I think we should indicate what a detached state is & indicate why creating a project is useful. Let me know your thoughts, I'll run through it with @rawktron in our stand as well.

Detached State
--------------
Your changes are local and will not be saved the cloud. Visit...
· Visit https://platform.activestate.com/commit/ebb055557-45648-45648-45648 
...to create a project at this point and create a reusable runtime.

For more information, including how to attach to an existing project, visit...
· https://docs.activestate.com/platform/state/advanced-topics/headless

Not particularly hot on saved to the cloud, if you have any ideas to convey that it would be helpful, I'll think some more too.

cc @Naatan

Yeah, to the cloud is weird. Can we just say "the platform" instead of "the cloud"? You have a double "Visit" in there. Also use a colon and no ellipsis.

Also double create in the CTA line is weird. You only need one.

Is there a place to just edit this copy directly?

@Naatan
Copy link
Copy Markdown
Contributor Author

Naatan commented Feb 23, 2021

Here's the latest with Pete's suggestions integrated:

image

# Conflicts:
#	changelog.md
#	locale/en-us.yaml
@Naatan Naatan merged commit 07ab449 into master Feb 23, 2021
@Naatan Naatan deleted the pr/176809621 branch February 23, 2021 18:57
Naatan added a commit that referenced this pull request Feb 23, 2021
Added headless state notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants