Facilitate incremental download of packages#1331
Merged
Conversation
Naatan
previously approved these changes
Apr 29, 2021
Contributor
Naatan
left a comment
Naatan
left a comment
There was a problem hiding this comment.
Looks ok to me. Did you consider how this affects the env merging at the end?
Comment on lines
+28
to
+29
| func (s *Setup) DeleteOutdatedArtifacts(changeset artifact.ArtifactChangeset, storedArtifacted store.StoredArtifactMap) ([]artifact.ArtifactID, error) { | ||
| var alreadyInstalled []artifact.ArtifactID |
Contributor
There was a problem hiding this comment.
Not going to request changes on this now, but this seems like something we should fix in the future. It's awkward that a function responsible for deleting outdated artifacts is returning artifacts that you want to keep. Either this function needs to be renamed or its logic needs to be split up into separate functions.
Contributor
Author
There was a problem hiding this comment.
I agree. I pushed a new version, that also gets rid of the go-funk dependency...
Naatan
pushed a commit
that referenced
this pull request
May 6, 2021
…d-177290892 Facilitate incremental download of packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/177290892