Fixed failing integration test.#2330
Merged
mitchell-as merged 1 commit intoversion/0-37-0-RC1from Jan 30, 2023
Merged
Conversation
The runtime progress refactor left out this notice.
github-actions
Bot
changed the base branch from
version/0-37-0-RC1
to
version/0-37-0-RC1
Naatan
approved these changes
Jan 30, 2023
Naatan
pushed a commit
that referenced
this pull request
Jan 30, 2023
Fixed failing integration test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime progress refactor left out this notice.
Note we have two options for this PR: add the notice back, or delete the expectation from the failing unit test. I chose the former because the unit test is intentionally looking for the notice, so I think there's an expected UX element here.