add trip scheduling choice explicit chunking - #1102
Merged
Merged
Conversation
# Conflicts: # activitysim/abm/test/test_misc/test_trip_scheduling_choice.py
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit chunk sizing to trip scheduling while preserving deterministic results.
Changes:
- Adds the
explicit_chunkmodel setting and forwards it to the chunker. - Adds coverage for chunk sizes and result equivalence.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
activitysim/abm/models/trip_scheduling_choice.py |
Implements explicit chunk configuration. |
activitysim/abm/test/test_misc/test_trip_scheduling_choice.py |
Tests deterministic explicit chunking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thanks @jpn-- for following up on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces and advances #1041.
This pull request adds support for explicit chunk sizing in the
trip_scheduling_choicemodel, allowing users to control how data is split during processing. It also introduces comprehensive tests to ensure that explicit chunking works correctly and does not affect model results.Explicit chunking support:
explicit_chunkparameter toTripSchedulingChoiceSettings, enabling users to specify a fixed chunk size or a fraction of the dataset for chunking.run_trip_scheduling_choiceto pass theexplicit_chunksetting tochunk.adaptive_chunked_choosers, ensuring the chunking behavior follows user configuration.Testing enhancements:
run_trip_scheduling_choiceto use deep copies and proper random-number management, ensuring reproducibility when chunking is enabled. [1] [2]