feat(release): enable start-at-login by default in research Qt builds - #1426
Conversation
- New scripts/patch_research_edition_awqt.py flips aw-qt's autostart_on_first_run default to true (aw-qt#131) in research builds, fail-closed if the submodule pin predates the option - Wired into both Qt build jobs' research patch step (build-qt and build-qt-manylinux-2-28); build-tauri untouched (doesn't bundle aw-qt) - getversion.sh: exclude *-research tags from the dev-version fallback so master dev builds stop reporting a research base version (v0.14.0b4-research.dev-* -> v0.14.0b4.dev-*); exact-match keeps them so building on a research tag still reports the research version
Greptile SummaryThe PR enables first-run start-at-login for Research Edition Qt bundles while preserving the standard and Tauri build paths, and prevents research tags from becoming the base of ordinary development versions.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issues identified. The research-only workflow gating, pre-build patch ordering, fail-closed marker check, canonical tag exclusion, and untouched exact-tag behavior align with the repository’s Qt packaging and release-version contracts. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
Trigger[Release workflow] --> Edition{Research edition?}
Edition -- No --> Standard[Build unchanged Qt artifacts]
Edition -- Yes --> Window[Patch research watcher defaults]
Window --> Qt[Patch aw-qt first-run autostart default]
Qt --> Build[Build Qt bundle]
Build --> Artifact[Research Windows, macOS, or Linux artifact]
Tags[Git tags] --> Exact{HEAD exactly tagged?}
Exact -- Yes --> ExactVersion[Keep exact tag, including research suffix]
Exact -- No --> Fallback[Find latest non-research tag]
Fallback --> DevVersion[Generate development version]
Reviews (1): Last reviewed commit: "build(deps): updated submodule (aw-qt: a..." | Re-trigger Greptile |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Study-readiness follow-ups for the Research Edition (Qt bundle is the study deliverable; participants are Windows/macOS):
scripts/patch_research_edition_awqt.py: research builds flip aw-qt's newautostart_on_first_rundefault (aw-qt#131, merged) totrue, so participant machines register start-at-login on first launch with zero setup steps. The user's later tray choice is always respected (marker file; disable is never overridden). Fails closed if the aw-qt pin predates the option — a research build can't silently lose reboot-survival.build-qtandbuild-qt-manylinux-2-28);build-tauriuntouched since it doesn't bundle aw-qt.getversion.sh: exclude*-researchtags from the dev-version fallback — master dev builds currently reportv0.14.0b4-research.dev-<sha>becausegit describepicks the research tag as nearest. Exact-match is deliberately untouched: building on a research tag still reports the research version.Verified locally: patch script success/fail-closed/missing-file paths, getversion output on master (
v0.14.0b4.dev-0a9d836), workflow YAML parses, aw-qt test suite green on the bumped pin (103 passed).