fix(ci): use jq for dev-release check-run filter#1230
fix(ci): use jq for dev-release check-run filter#1230ErikBjare merged 1 commit intoActivityWatch:masterfrom
Conversation
Greptile SummaryThis PR fixes a broken CI-gate check in the Key changes:
The fix is targeted and correct; no unrelated lines were modified. Confidence Score: 5/5Safe to merge — the fix is minimal, targeted, and correctly addresses the root cause without introducing new issues. No P0 or P1 findings. The No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant WF as dev-release workflow
participant GH as gh api (GitHub REST)
participant JQ as jq
WF->>GH: GET /actions/runs/{run_id}<br/>--jq .check_suite_id
GH-->>WF: current_suite_id
WF->>GH: GET /commits/{sha}/check-runs<br/>--paginate --slurp
GH-->>GH: (follow pagination links)
GH-->>JQ: [ {check_runs:[...]}, {check_runs:[...]} ]
Note over JQ: --arg suite "$current_suite_id"<br/>filter: app.slug==github-actions<br/>AND suite_id != current
JQ-->>WF: unique conclusions (success / failure / null …)
alt any failure / timed_out / cancelled
WF->>WF: should_release=false
else any null / pending
WF->>WF: should_release=false
else empty or unknown
WF->>WF: should_release=false
else only "success"
WF->>WF: should_release=true → push prerelease tag
end
Reviews (1): Last reviewed commit: "fix(ci): use jq for dev-release check-ru..." | Re-trigger Greptile |
Summary
Fix the merged dev-release workflow so it can actually read GitHub Actions conclusions and cut a prerelease tag.
Root cause
The workflow currently runs
gh api ... --arg suite ... --jq ..., but the GitHub CLI on the runner does not support--arg. The probe exits withunknown flag: --arg, gets swallowed by|| echo unknown, and the workflow always decidesCI status unavailable on HEAD, skipping dev release.This is exactly what happened in the manual verification run: https://github.com/ActivityWatch/activitywatch/actions/runs/23379388417
Changes
gh api --arg ... --jq ...usage withgh api --paginate --slurp | jq -r --arg ...jqValidation
d3affdc895a3c5aa586283200b039b4c6a17b0f8unknown(failure,skipped,success)Closes the remaining blocker from #1216 so the first automated dev prerelease can actually run.