Skip to content

fix(ci): pin Rust to 1.79.0 to avoid E0282 in time crate on 1.80+ #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimeToBuildBob wants to merge 1 commit into from
Closed

fix(ci): pin Rust to 1.79.0 to avoid E0282 in time crate on 1.80+ #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ jobs:
# Rust
- name: Set up Rust
id: toolchain
uses: dtolnay/rust-toolchain@stable
# Pin to 1.79.0: aw-server-rust@dc70318 uses `time` crate which fails to compile
# on Rust 1.80+ due to tightened type inference (E0282 in Box<_> expressions).
uses: dtolnay/rust-toolchain@1.79.0
Comment on lines +57 to +59
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 No tracking issue for the unpin

The comment explains the temporary nature of this pin, but without a linked GitHub issue the team may forget to revisit it when aw-server-rust updates its time dependency. Consider adding a TODO(#<issue>): reference so the pin stays on the radar and is easy to find later.

if: steps.cache-jniLibs.outputs.cache-hit != 'true'

- name: Set up Rust toolchain for Android NDK
Expand Down
Loading