Skip to content

api: Make insert event never return anything #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johan-bjareholt merged 2 commits into from
Mar 18, 2021
Merged

api: Make insert event never return anything #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe6b0b3
api: Make insert event never return anything
johan-bjareholt Mar 15, 2021
61b362a
chore: Fix linting issue
johan-bjareholt Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aw_server/__about__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def detect_version():
return basever + ".dev+unknown"


__version__ = 'v0.10.dev+32e3624'
__version__ = "v0.10.dev+32e3624"


def assign_static_version():
Expand Down
2 changes: 1 addition & 1 deletion aw_server/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def create_events(self, bucket_id: str, events: List[Event]) -> Optional[Event]:
"""Create events for a bucket. Can handle both single events and multiple ones.

Returns the inserted event when a single event was inserted, otherwise None."""
return self.db[bucket_id].insert(events[0] if len(events) == 1 else events)
return self.db[bucket_id].insert(events)

@check_bucket_exists
def get_eventcount(
Expand Down
6 changes: 3 additions & 3 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,9 @@ def test_list_buckets(aw_client, bucket):

def test_send_event(aw_client, bucket):
event = Event(timestamp=datetime.now(tz=timezone.utc), data={"label": "test"})
recv_event = aw_client.send_event(bucket, event)
assert recv_event.id is not None
assert recv_event == event
aw_client.send_event(bucket, event)
recv_events = aw_client.get_events(bucket, limit=1)
assert recv_events == [event]


def test_send_events(aw_client, bucket):
Expand Down