Skip to content

feat: Add custom hovertext for editor summary and project#217

Merged
johan-bjareholt merged 1 commit into
masterfrom
dev/summary-custom-hovertext
Jul 16, 2020
Merged

feat: Add custom hovertext for editor summary and project#217
johan-bjareholt merged 1 commit into
masterfrom
dev/summary-custom-hovertext

Conversation

@johan-bjareholt
Copy link
Copy Markdown
Member

No description provided.

Comment thread .github/workflows/nodejs.yml Outdated
node-version: ${{ matrix.node-version }}
- name: Install
run: npm ci
run: npm ci --force
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is destined to cause problems down the line, npm can do a lot of crazy stuff with --force. Not sure what to do instead though, I reran the original commit job for good measure.

@ErikBjare
Copy link
Copy Markdown
Member

ErikBjare commented Jul 16, 2020

Looks like the rerun https://github.com/ActivityWatch/aw-webui/actions/runs/167785545 of bbff399 (#217) didn't have the same error as the original run but instead had the weird e2e/aw-client-js/axios thing we've seen before:

 My fixture
 ✖ Take a screenshot of the activity view

   1) A JavaScript error occurred on
      "http://localhost:27180/#/activity/erb-main2-arch".
      Repeat test actions in the browser and check the console for errors.
      If you see this error, it means that the tested website caused it.
      You can fix it or disable tracking JavaScript errors in TestCafe. To
      do the latter, enable the "--skip-js-errors" option.
      If this error does not occur, please write a new issue at:

   "https://github.com/DevExpress/testcafe/issues/new?template=bug-report.md".

      JavaScript error details:
      Error: Module build failed: Error: ENOENT: no such file or
      directory, open

   '/home/runner/work/aw-webui/aw-webui/aw-client-js/node_modules/axios/index.js'

Edit: I re-ran it again, since your changes couldn't possibly have broken it.

@ErikBjare
Copy link
Copy Markdown
Member

I see now that:

Error: Command failed: xvfb-run --server-args="-screen 0 1280x720x24" npx testcafe chrome test/e2e/

Note the screen size.

And the error happens on:

          5 |test('Take a screenshot of the activity view', async t => {
          6 |  const width = 1280;
          7 |  const height = 800;
          8 |  await t
          9 |    // For resizeWindow to work tests needs to run with a
      ICCCM/EWMH-compliant window manager
       > 10 |    .resizeWindow(width, height)
         11 |    .click('#load-demo')
         12 |    // TODO: Figure out how to click all hide-devonly buttons
      instead of hardcoding number of clicks
         13 |    .click('.hide-devonly')
         14 |    .click('.hide-devonly');
         15 |

Where the screen size is larger than the one set up by xvfb.

In another passing build I found the warning:

 Warnings (1):
 --
  Was unable to resize the window due to an error.

  The
  /home/runner/work/aw-webui/aw-webui/node_modules/testcafe-browser-tools/bin/linux/glibc-64/resize
  process failed with the null exit code.

So we should probably fix that.

@ErikBjare
Copy link
Copy Markdown
Member

Once #221 is merged you can rebase on master, drop the --force commit, and it should work.

@johan-bjareholt johan-bjareholt force-pushed the dev/summary-custom-hovertext branch from dd51582 to 437a882 Compare July 16, 2020 13:10
@johan-bjareholt
Copy link
Copy Markdown
Member Author

@ErikBjare Nice, seems to work! 😄

@johan-bjareholt johan-bjareholt merged commit e0d26ec into master Jul 16, 2020
@johan-bjareholt johan-bjareholt deleted the dev/summary-custom-hovertext branch July 16, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants