fix: register cta and info-box in DEFAULT_COMPONENTS#8
Merged
Conversation
The Cta and InfoBox components and their styles already shipped, but the tags required manual registration to work — unlike button/callout/wrapper which are registered by default. Add 'cta' and 'info-box' to DEFAULT_COMPONENTS so they work out of the box. Bump to 1.1.1.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problème
Les composants
CtaetInfoBox(et leurs styles SCSS) sont fournis par la gem, mais les tags<cta>/<info-box>n'étaient pas enregistrés par défaut dansDEFAULT_COMPONENTS— contrairement àbutton,callout,wrapper, etc. Résultat : sansregister_componentmanuel,<cta>/<info-box>ressortent en tags bruts non transformés.Correctif
Ajout de
'cta' => ActiveMail::Components::Ctaet'info-box' => ActiveMail::Components::InfoBoxàDEFAULT_COMPONENTS. Les deux tags fonctionnent désormais out of the box. Bump 1.1.1.Impact
Additif et rétrocompatible. Les apps qui enregistraient déjà ces tags (ou des alias type
<ds-cta>) ne sont pas affectées (le registre custom prime). Permet de retirer les shims/alias dépréciés côté app.Tests
Suite complète verte (282 runs) + rubocop.