Skip to content

deps: repoint lance-graph git deps from the feature branch to main - #302

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/patient-identity-architecture-r8lhi5
Sep 6, 2026
Merged

deps: repoint lance-graph git deps from the feature branch to main#302
AdaWorldAPI merged 1 commit into
mainfrom
claude/patient-identity-architecture-r8lhi5

Conversation

@claude

@claude claude Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

What

AdaWorldAPI/lance-graph#1206 (the Axis-4 WideFieldMask widening) is merged, so main now carries the widened ClassRbac::field_mask that ogar-auth and ogar-rbac were pinned to a feature branch to reach.

-lance-graph-contract = { git = "…/lance-graph", branch = "claude/patient-identity-architecture-r8lhi5" }
+lance-graph-contract = { git = "…/lance-graph", branch = "main" }
-lance-graph-rbac     = { git = "…/lance-graph", branch = "claude/patient-identity-architecture-r8lhi5" }
+lance-graph-rbac     = { git = "…/lance-graph", branch = "main" }

Why this is not cosmetic

Pointing at a feature branch was correct only while that branch was the sole place the widened trait existed — main would not have compiled. Once #301 merged, though, OGAR main was depending on a branch that can be deleted the moment its PR merges, at which point main stops resolving its dependencies. This closes that window.

Three lines, two files, no code change.

Verified

  • Resolves to main#2918421.
  • ogar-auth 19/19, ogar-rbac 7/7.
  • cargo fmt --check and cargo clippy -D warnings clean.

Branch restarted from main rather than stacked, since its predecessor (#301) is already merged.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PGkLH5cYiiWM4QmNkvBBvf


Generated by Claude Code

AdaWorldAPI/lance-graph#1206 (the Axis-4 WideFieldMask widening) is
merged, so `main` now carries the widened `ClassRbac::field_mask` these
crates were pinned to a branch to reach.

Leaving the branch ref on OGAR main was the real exposure: a branch can
be deleted after its PR merges, and OGAR main would then stop resolving
its dependencies. Pointing at a feature branch was correct only while
that branch was the sole place the widened trait existed.

Resolves to main#2918421. ogar-auth 19/19, ogar-rbac 7/7, fmt and
clippy -D warnings clean.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PGkLH5cYiiWM4QmNkvBBvf
@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review September 6, 2026 13:51
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@AdaWorldAPI
AdaWorldAPI merged commit 97e0bf2 into main Sep 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants