deps: repoint lance-graph git deps from the feature branch to main - #302
Merged
Merged
Conversation
AdaWorldAPI/lance-graph#1206 (the Axis-4 WideFieldMask widening) is merged, so `main` now carries the widened `ClassRbac::field_mask` these crates were pinned to a branch to reach. Leaving the branch ref on OGAR main was the real exposure: a branch can be deleted after its PR merges, and OGAR main would then stop resolving its dependencies. Pointing at a feature branch was correct only while that branch was the sole place the widened trait existed. Resolves to main#2918421. ogar-auth 19/19, ogar-rbac 7/7, fmt and clippy -D warnings clean. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PGkLH5cYiiWM4QmNkvBBvf
AdaWorldAPI
marked this pull request as ready for review
September 6, 2026 13:51
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AdaWorldAPI/lance-graph#1206 (the Axis-4
WideFieldMaskwidening) is merged, somainnow carries the widenedClassRbac::field_maskthatogar-authandogar-rbacwere pinned to a feature branch to reach.Why this is not cosmetic
Pointing at a feature branch was correct only while that branch was the sole place the widened trait existed —
mainwould not have compiled. Once #301 merged, though, OGARmainwas depending on a branch that can be deleted the moment its PR merges, at which pointmainstops resolving its dependencies. This closes that window.Three lines, two files, no code change.
Verified
main#2918421.ogar-auth19/19,ogar-rbac7/7.cargo fmt --checkandcargo clippy -D warningsclean.Branch restarted from
mainrather than stacked, since its predecessor (#301) is already merged.🤖 Generated with Claude Code
https://claude.ai/code/session_01PGkLH5cYiiWM4QmNkvBBvf
Generated by Claude Code