Board: make the supersession index actually generated — its commentary too - #1044
Merged
Conversation
…ry too The committed file said 'GENERATED, do not edit' and I hand-annotated it after generating. Running the documented regenerate command would have wiped 41 lines of analysis -- the exact failure the file warns about, in the same commit that warned about it. Caught by the check written into that PR's own follow-up, on its first run. The fix is not to relax the header. The commentary now interpolates every measurement from the same values as the tables, so prose and table cannot disagree: methods stay literal, measurements never are. Verified idempotent -- two consecutive runs produce byte-identical output. Also fixed a selector defect visible only by reading the generated prose: CollapseGateEmission filled both the all-blind slot and the rename slot, and a tombstone is not a rename. The rename slot now requires a named successor and cannot reuse the previous pick, so it selects ResonanceDto -> PerturbationDto, which is the case that actually illustrates the rule. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AGVLyRZNEKKBSfBDJfbY3V
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_ab5fc1ca-34f4-43d9-a9da-2a3a86e48df8) |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AdaWorldAPI
marked this pull request as ready for review
August 26, 2026 07:48
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Board + tools. No source change.
The defect
#1043 shipped a file headed "GENERATED, do not edit" that I then hand-annotated after generating. Running its own documented regenerate command would have wiped 41 lines of analysis — the exact failure the file warns about, in the commit that warned about it.
Caught by the verification written into that PR's follow-up check, on its first run:
The fix
Not relaxing the header. The commentary is now generated too, interpolating every measurement from the same values as the tables — so prose and table cannot disagree:
BindSpace's "67 crate files, 41 plans, 40 blind" is no longer typed into prose that will be wrong after the next rename; it is the same computed value the table row uses. Verified idempotent — two consecutive runs are byte-identical.A second defect, visible only by reading the generated prose
The first self-generating version put
CollapseGateEmissionin two slots — the all-blind case and the rename case — because the selector maximisedplans − crates(12−5=7) overResonanceDto(6−2=4). But a tombstone is not a rename.CollapseGateEmissionhas no successor; it is already tombstoned (PR #477).The rename slot now requires a named successor and cannot reuse the previous pick, so it selects the case that actually illustrates the rule:
Worth noting how that one surfaced: not by a gate, but by reading the output the generator produced. A byte-identical regeneration proves the file is reproducible, never that it is right.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AGVLyRZNEKKBSfBDJfbY3V
Generated by Claude Code