Skip to content

Collapse a double blank line rustfmt rejects - #1214

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/ndarray-simd-tract-o3jfrn
Sep 7, 2026
Merged

Collapse a double blank line rustfmt rejects#1214
AdaWorldAPI merged 1 commit into
mainfrom
claude/ndarray-simd-tract-o3jfrn

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

cargo fmt --all -- --check fails on crates/lance-graph-ogar/src/lib.rs:648 — two consecutive blank lines where rustfmt's blank_lines_upper_bound allows one. One deleted line; no behaviour change.

Why it matters beyond this repo

Consumers whose CI checks this repo out beside their own and runs a workspace-wide cargo fmt --all -- --check inherit the failure. It was found from AdaWorldAPI/q2#152, whose own sources were already clean — that PR's Rustfmt (check) step reports the diff at this path and cannot go green until this lands on main, because q2's workflow checks this repository out with no ref: and therefore reads the default branch.

Verification

  • rustfmt --edition 2021 --check crates/lance-graph-ogar/src/lib.rs → clean (was a 1-line diff).
  • cargo fmt --all -- --check across this workspace → 0 diffs.

Board hygiene

No type, plan, deliverable, or epiphany is added — this is a one-line formatting fix, so it generates none of the board obligations.

🤖 Generated with Claude Code

https://claude.ai/code/session_012wrzeZAdwGYTCKoxamwQht


Generated by Claude Code

`cargo fmt --all -- --check` fails on lance-graph-ogar/src/lib.rs:648 —
two consecutive blank lines where rustfmt's blank_lines_upper_bound
allows one. It reddens every consumer whose CI checks this repo out
beside its own and runs a workspace-wide fmt check (found from
AdaWorldAPI/q2#152, whose own sources were already clean).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012wrzeZAdwGYTCKoxamwQht
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 1 minute.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 60 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 239ea146-9a9e-4b61-9e1a-bd986ebf1fba

📥 Commits

Reviewing files that changed from the base of the PR and between 7130714 and 4c5db24.

📒 Files selected for processing (1)
  • crates/lance-graph-ogar/src/lib.rs

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 7, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_9f753340-3b21-45eb-9bcb-b396878af58f)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review September 7, 2026 06:28
@AdaWorldAPI
AdaWorldAPI merged commit 8ad8555 into main Sep 7, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants