contract::ogar_codebook — mirror the harvest-derived Health mints (0x0908..0x090C)#675
Conversation
Paired with the OGAR-side mint (two-sided COUNT_FUSE drift fuse: lance-graph-ogar compile-time assert now 88 == 88). Same rows, same order as ogar-vocab CODEBOOK: anamnesis / investigation / examination / practitioner — harvest-derived, no OGIT entity, no port alias yet. Co-Authored-By: Claude <noreply@anthropic.com>
Paired with OGAR 13e1b0f (two-sided COUNT_FUSE: 89 == 89). Same row, same order as ogar-vocab CODEBOOK; the 0x09 section comment notes the 0x0908..0x090C harvest-mint range and external_practice's three-axis grounding. LATEST_STATE prepended per board-hygiene rule. Co-Authored-By: Claude <noreply@anthropic.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_531202f4-2198-44d8-97cc-2fecdda19e77) |
|
Warning Review limit reached
Next review available in: 54 seconds Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Health ChangesHealth codebook
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
crates/lance-graph-contract/src/ogar_codebook.rs (1)
714-716: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd test assertions for the new Health entries.
The existing
codebook_ids_match_ogar_vocabtest covers Health entriespatient(0x0901) andvital_sign(0x0907) but does not cover the newly added entries0x0908–0x090C. Per coding guidelines, Rust unit tests should accompany implementations in#[cfg(test)]modules. While the cross-crate parity guard inlance-graph-ogarprovides bijection validation, local assertions give faster feedback and follow the guideline.As per coding guidelines: "Add Rust unit tests alongside implementations via
#[cfg(test)]modules; prefer focused scenarios over broad integration tests."♻️ Proposed test additions
// 0x09XX Health + 0x0BXX Auth (OGAR `#110` minted the AuthStore family). assert_eq!(canonical_concept_id("patient"), Some(0x0901)); assert_eq!(canonical_concept_id("vital_sign"), Some(0x0907)); + // 0x0908..0x090C harvest-derived Health mints (OGAR PR `#189`). + assert_eq!(canonical_concept_id("anamnesis"), Some(0x0908)); + assert_eq!(canonical_concept_id("practitioner"), Some(0x090B)); + assert_eq!(canonical_concept_id("external_practice"), Some(0x090C)); assert_eq!(canonical_concept_id("auth_store"), Some(0x0B01));🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/lance-graph-contract/src/ogar_codebook.rs` around lines 714 - 716, Add assertions in the existing `codebook_ids_match_ogar_vocab` test for each newly added Health entry, verifying `canonical_concept_id` maps the relevant symbols to IDs 0x0908 through 0x090C. Keep the assertions alongside the existing `patient` and `vital_sign` checks in the local `#[cfg(test)]` module.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@crates/lance-graph-contract/src/ogar_codebook.rs`:
- Around line 714-716: Add assertions in the existing
`codebook_ids_match_ogar_vocab` test for each newly added Health entry,
verifying `canonical_concept_id` maps the relevant symbols to IDs 0x0908 through
0x090C. Keep the assertions alongside the existing `patient` and `vital_sign`
checks in the local `#[cfg(test)]` module.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d6e713fc-8402-4c81-8a74-891776d6438a
📒 Files selected for processing (2)
.claude/board/LATEST_STATE.mdcrates/lance-graph-contract/src/ogar_codebook.rs
…odebook-handover-5ulx0i # Conflicts: # .claude/board/LATEST_STATE.md
Summary
Mirrors the five harvest-derived Health concepts minted upstream in OGAR (
anamnesis 0x0908…external_practice 0x090C) into the zero-deplance-graph-contract::ogar_codebooktable. This is the paired half of the two-sidedCOUNT_FUSEdrift guard:lance-graph-ogarcarries a compile-time assert that the mirror length equalsogar_vocab::class_ids::ALL, so the mirror must move in lockstep with the OGAR codebook.What's in the diff
lance-graph-contract/src/ogar_codebook.rs: +5 CODEBOOK rows (same order as the OGAR side); the0x09XXsection comment records the harvest-mint range andexternal_practice's three-axis grounding (FHIROrganization)..claude/board/LATEST_STATE.md: prepended entry per the board-hygiene rule (same commit).Merge order
Paired with OGAR PR #189. Merge that first (it bumps
class_ids::ALLto the count this mirror now equals); merge this one immediately after so thelance-graph-ogarfuse compiles (89 == 89). Then the MedCare-rs consumer PR. Freeze other lance-graph/medcare merges during the window.Test Plan
cargo test --manifest-path crates/lance-graph-ogar/Cargo.toml— fuse compiles, 62+ tests green (against OGAR head)cargo test -p lance-graph-contract— 840 lib tests green🤖 Generated with Claude Code
Generated by Claude Code
Summary by CodeRabbit
New Features
Documentation