fix: resolve clients/projects save failures with three targeted fixes#154
Merged
Conversation
Bug 1 — stale closure in forceSyncToDatabase: ProjectList.tsx calls addProject/updateProject/archiveProject and then immediately awaits forceSyncToDatabase(). Because React state updates are asynchronous, the `projects` captured in forceSyncToDatabase's useCallback closure is the pre-mutation list — so the just-added/changed project is never included in the save. Fix: add a projectsRef (mirroring the existing clientsRef pattern) that is updated synchronously in every project mutation and during loadData. forceSyncToDatabase now reads projectsRef.current instead of the closure variable, and `projects` is removed from its dep array. Bug 2 — client mutations wrongly set hasUnsavedChanges: addClient, archiveClient, and restoreClient called setHasUnsavedChanges(true) even though callers immediately persist the change via persistClient / persistClients. This left the save icon orange after every client operation even when the data was already written. Since clients are excluded from forceSyncToDatabase's bulk save, clearing hasUnsavedChanges via that path was unrelated to whether the client data was safe. Fix: remove the setHasUnsavedChanges(true) calls from the three client mutators. Bug 3 — saved edits to default projects discarded on reload: The project load merge always started from hardcoded defaults and only appended saved projects whose name+client didn't match any default. A saved modified default (same name+client, different hourlyRate or color) was silently dropped and replaced by the hardcoded version. Fix: when a saved project matches a default by name+client, replace the default entry with the saved one rather than skipping it. https://claude.ai/code/session_01K9hQPH6ddsadiAF19VGnJQ
github-actions
Bot
added
the
documentation
AdamJ
pushed a commit
that referenced
this pull request
May 31, 2026
…tabase forceSyncToDatabase was closing over the React state value `plannedTasks` (initially []) rather than `plannedTasksRef.current`. If the function fired before the initial Supabase load completed (e.g. online event, manual sync button, category/project save in another component), it called savePlannedTasks([]) which hit the delete-all branch and wiped the table. Mirrors the projectsRef fix from #154: update plannedTasksRef.current synchronously in loadData and in every mutation (addPlannedTask, updatePlannedTask, deletePlannedTask, movePlannedTask, pullPlannedTaskToDay), use plannedTasksRef.current in forceSyncToDatabase, and drop plannedTasks from its dependency array. https://claude.ai/code/session_01CJG4Vxc5RpXbuF1NuWF4cG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1 — stale closure in forceSyncToDatabase:
ProjectList.tsx calls addProject/updateProject/archiveProject and then
immediately awaits forceSyncToDatabase(). Because React state updates are
asynchronous, the
projectscaptured in forceSyncToDatabase's useCallbackclosure is the pre-mutation list — so the just-added/changed project is
never included in the save. Fix: add a projectsRef (mirroring the existing
clientsRef pattern) that is updated synchronously in every project mutation
and during loadData. forceSyncToDatabase now reads projectsRef.current
instead of the closure variable, and
projectsis removed from its deparray.
Bug 2 — client mutations wrongly set hasUnsavedChanges:
addClient, archiveClient, and restoreClient called setHasUnsavedChanges(true)
even though callers immediately persist the change via persistClient /
persistClients. This left the save icon orange after every client operation
even when the data was already written. Since clients are excluded from
forceSyncToDatabase's bulk save, clearing hasUnsavedChanges via that path
was unrelated to whether the client data was safe. Fix: remove the
setHasUnsavedChanges(true) calls from the three client mutators.
Bug 3 — saved edits to default projects discarded on reload:
The project load merge always started from hardcoded defaults and only
appended saved projects whose name+client didn't match any default. A saved
modified default (same name+client, different hourlyRate or color) was
silently dropped and replaced by the hardcoded version. Fix: when a saved
project matches a default by name+client, replace the default entry with the
saved one rather than skipping it.
https://claude.ai/code/session_01K9hQPH6ddsadiAF19VGnJQ