fix: prevent planned tasks deletion by stale closure in forceSyncToDatabase#157
Merged
Conversation
…tabase forceSyncToDatabase was closing over the React state value `plannedTasks` (initially []) rather than `plannedTasksRef.current`. If the function fired before the initial Supabase load completed (e.g. online event, manual sync button, category/project save in another component), it called savePlannedTasks([]) which hit the delete-all branch and wiped the table. Mirrors the projectsRef fix from #154: update plannedTasksRef.current synchronously in loadData and in every mutation (addPlannedTask, updatePlannedTask, deletePlannedTask, movePlannedTask, pullPlannedTaskToDay), use plannedTasksRef.current in forceSyncToDatabase, and drop plannedTasks from its dependency array. https://claude.ai/code/session_01CJG4Vxc5RpXbuF1NuWF4cG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forceSyncToDatabase was closing over the React state value
plannedTasks(initially []) rather than
plannedTasksRef.current. If the function firedbefore the initial Supabase load completed (e.g. online event, manual sync
button, category/project save in another component), it called
savePlannedTasks([]) which hit the delete-all branch and wiped the table.
Mirrors the projectsRef fix from #154: update plannedTasksRef.current
synchronously in loadData and in every mutation (addPlannedTask,
updatePlannedTask, deletePlannedTask, movePlannedTask, pullPlannedTaskToDay),
use plannedTasksRef.current in forceSyncToDatabase, and drop plannedTasks
from its dependency array.
https://claude.ai/code/session_01CJG4Vxc5RpXbuF1NuWF4cG