Skip to content
This repository was archived by the owner on Nov 27, 2025. It is now read-only.

cmake: prefer pkgconf for finding Linux deps#166

Merged
Adamcake merged 3 commits intoAdamcake:masterfrom
pajlada:fix/cmake-pkgconf
Sep 20, 2025
Merged

cmake: prefer pkgconf for finding Linux deps#166
Adamcake merged 3 commits intoAdamcake:masterfrom
pajlada:fix/cmake-pkgconf

Conversation

@pajlada
Copy link
Copy Markdown
Contributor

@pajlada pajlada commented Aug 23, 2025

Not sure if this really counts as adding a dependency - every development setup I've set up has had either pkgconf or pkg-config preinstalled, so I can revert the readme update if you prefer.

@Adamcake
Copy link
Copy Markdown
Owner

Don't you need to change this one too?

target_link_libraries(${BOLT_PLUGIN_LIB_NAME} luajit-5.1)

@pajlada
Copy link
Copy Markdown
Contributor Author

pajlada commented Aug 26, 2025

Don't you need to change this one too?

target_link_libraries(${BOLT_PLUGIN_LIB_NAME} luajit-5.1)

Good catch, I'll take a look at that too. I was building without libraries when testing

@pajlada pajlada force-pushed the fix/cmake-pkgconf branch from 5d3e82d to 81ff8c8 Compare August 27, 2025 17:23
@pajlada pajlada force-pushed the fix/cmake-pkgconf branch from 81ff8c8 to 1a7083c Compare August 27, 2025 17:27
@pajlada
Copy link
Copy Markdown
Contributor Author

pajlada commented Aug 27, 2025

1a7083c (#166) is unrelated to pkgconf but still related to cmake. It should've been part of the original CEF build but I got lost in my commits.
Let me know if you want me to rebase it away for a separate PR

Additionally, there's one thing still missing for a full out-of-the-box Fedora build, but it's a bit more messy: Fedora system CEF builds with a later version, meaning function method params to OnBeforePopup differ (see chromiumembedded/cef@e513077). My intent is to solve that in a followup PR.

@Adamcake
Copy link
Copy Markdown
Owner

CEF versions don't seem to have stable APIs, but the OnBeforePopup thing thankfully happens to be the only breaking change in the last year or two. At some point I will be getting round to updating my own CEF builds to 139 and that issue will be moot, until they break something else.

@Adamcake Adamcake merged commit 07c046e into Adamcake:master Sep 20, 2025
2 checks passed
@pajlada pajlada deleted the fix/cmake-pkgconf branch September 20, 2025 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants