refactor: update to svelte 5#172
refactor: update to svelte 5#172Adamcake merged 10 commits intoAdamcake:masterfrom natural-stupidity:master
Conversation
|
The |
|
Okay, doesn't work for me I'm afraid. If I'm not logged in to any account then it's fine, but after logging in, or after re-opening the launcher while logged in, I get this: Dropdown.svelte:37 is the |
|
That was after running |
Ah, sorry about that. It should be fixed now, but definitely let me know if you run into anything else |
|
Thanks - looks about right now. I only noticed one odd detail, which is, when adding a new plugin in the RS3 plugin menu, the drop-down list of plugins doesn't update anymore until the menu is closed and re-opened. The new plugin becomes the active one, as expected, but it's not available in the drop-down list. I can't immediately see why that is, as the only change you made to that drop-down was In case you need plugins for testing, here are a few URLs you can enter in the "add from URL" box. |
|
Should be updated now to refresh after importing or adding plugins. I ran into an issue with the "Browse config" button in the plugin modal. Whenever I click it, I get a |
|
From memory, I don't think that a plugin would have a config directory until the first time it's launched, or possibly even until it attempts to save a config file, so I wouldn't worry about that. |
|
Okay, one last thing before I'll merge this. After your version bumps, eslint (script: |
Yeah, I saw that earlier, but neglected to update, so I went back and did it (00dd370). The only thing I had to change was an eslint rule about ignoring unused variables in catch blocks. It should be good now |
Ref: #85
Note: I'm pretty new to svelte-5 and I'm still figuring stuff out.
It goes without saying - please call me out if I messed anything up. Feedback is really appreciated.
I'll probably edit this PR (and this description) as I go along.
Changes Made
.vscodefolders and added them to.gitignorefilesModalsfolder in components