[VK] Handle kernel arguments set via uniform buffers - #2186
Draft
EwanC wants to merge 1 commit into
Draft
Conversation
This patch updates the Vulkan backend to correctly handle when a SPIR-V kernel expects arguments to be passed via uniform buffers instead of push constants. This requires creating uniform buffers and descriptor sets that can be used on a kernel invocation without conflicting with other invocations of the same kernel. This path is less efficient than pushing constants to set arguments but is used as workaround for the Qualcomm Adreno GPU Vulkan driver which struggles to correctly execute well formed SPIR-V code where ulong device buffer addresses are passed in the push constant struct. The clspv PR google/clspv#1623 is required for the full stack to work.
EwanC
added a commit
to EwanC/adaptivecpp.github.io
that referenced
this pull request
Aug 12, 2026
Create a blog post on the recent AdaptiveCpp developments of a Vulkan backend that can run on Android. Using placeholders for blog date as we need these two AdaptiveCpp PRs to merge first: * AdaptiveCpp/AdaptiveCpp#2186 * AdaptiveCpp/AdaptiveCpp#2158
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates the Vulkan backend to correctly handle when a SPIR-V kernel expects arguments to be passed via uniform buffers instead of push constants. This requires creating uniform buffers and descriptor sets that can be used on a kernel invocation without conflicting with other invocations of the same kernel.
This path is less efficient than pushing constants to set arguments but is used as workaround for the Qualcomm Adreno GPU Vulkan driver on Android which struggles to correctly execute well formed SPIR-V code where ulong device buffer addresses are passed in the push constant struct.