Skip to content

Update dist#112

Closed
GetContented wants to merge 1 commit intoAddepar:masterfrom
GetContented:master
Closed

Update dist#112
GetContented wants to merge 1 commit intoAddepar:masterfrom
GetContented:master

Conversation

@GetContented
Copy link
Copy Markdown

Re-grunted to update the dist folder

@azirbel
Copy link
Copy Markdown
Contributor

azirbel commented Mar 24, 2014

@JulianLeviston could you explain how you built these changed files? It looks like our dist folder is inconsistent with master, but when I checkout master and run grunt I seem to get a different diff than what you've posted here. Could be a mistake on my end though.

@GetContented
Copy link
Copy Markdown
Author

Oh yeah sure. Sorry :) I just forked, cloned my fork to my mac book pro, ran grunt and stopped it when it said "running task wait". Then I committed and pushed then created the pr. Seemed pretty standard. Hope I did it right?

Sent from my self advertising device

On 24 Mar 2014, at 7:03 pm, Alex Zirbel notifications@github.com wrote:

@JulianLeviston could you explain how you built these changed files? It looks like our dist folder is inconsistent with master, but when I checkout master and run grunt I seem to get a different diff than what you've posted here. Could be a mistake on my end though.


Reply to this email directly or view it on GitHub.

@azirbel
Copy link
Copy Markdown
Contributor

azirbel commented Mar 26, 2014

Hey @JulianLeviston, sorry for being so slow on this.

Weird stuff! I haven't been able to find out why you get different results yet, but:

  • If I clone out your fork of the repo, then git checkout HEAD~1, npm install & grunt, then I get the same diff you have submitted here.
    • If I check out our repo master, git clean -dfx, npm install & grunt, then I get a different diff.

Having a diff at all is a problem and needs fixing no matter what. But first I'd like to figure out why you get something different. Any ideas?

@GetContented
Copy link
Copy Markdown
Author

Hehe actually I don't have any ideas, unfortunately :( You should use your own, tho... I was just doing it to save someone some work.

@azirbel
Copy link
Copy Markdown
Contributor

azirbel commented Mar 27, 2014

Ok. I appreciate it - thank you! I think #106 is going out soon, so we'll update dist as part of that. It's not the best situation to be in, but for now I think the solution is to just be more consistent about updating dist with every PR.

@azirbel azirbel closed this Mar 27, 2014
Gaurav0 pushed a commit to Gaurav0/ember-table that referenced this pull request Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants