Update dist#112
Conversation
|
@JulianLeviston could you explain how you built these changed files? It looks like our dist folder is inconsistent with master, but when I checkout master and run grunt I seem to get a different diff than what you've posted here. Could be a mistake on my end though. |
|
Oh yeah sure. Sorry :) I just forked, cloned my fork to my mac book pro, ran grunt and stopped it when it said "running task wait". Then I committed and pushed then created the pr. Seemed pretty standard. Hope I did it right? Sent from my self advertising device
|
|
Hey @JulianLeviston, sorry for being so slow on this. Weird stuff! I haven't been able to find out why you get different results yet, but:
Having a diff at all is a problem and needs fixing no matter what. But first I'd like to figure out why you get something different. Any ideas? |
|
Hehe actually I don't have any ideas, unfortunately :( You should use your own, tho... I was just doing it to save someone some work. |
|
Ok. I appreciate it - thank you! I think #106 is going out soon, so we'll update dist as part of that. It's not the best situation to be in, but for now I think the solution is to just be more consistent about updating dist with every PR. |
Apply inner column styles in runtime.
Re-grunted to update the dist folder