'template'/'templateName' is not appropriate for components that are reg...#90
Merged
ppong merged 1 commit intoAddepar:masterfrom Dec 31, 2013
asaf:componentWithLayout
Merged
'template'/'templateName' is not appropriate for components that are reg...#90ppong merged 1 commit intoAddepar:masterfrom asaf:componentWithLayout
ppong merged 1 commit intoAddepar:masterfrom
asaf:componentWithLayout
Conversation
…registered via Handlebars.helper, layoutName should be used instead, for more info, please see: emberjs/ember.js#4030.
ppong
pushed a commit
that referenced
this pull request
Dec 31, 2013
'template'/'templateName' is not appropriate for components that are reg...
Contributor
|
thanks @asaf |
|
Probably should rebuild dist. I started using it and then realised this was the case and manualy patched it and was going to submit a PR when I realised it had already been done. I guess I should build it myself rather than use dist? |
Contributor
|
@JulianLeviston let's discuss on the PR you submitted - #112 |
Gaurav0
pushed a commit
to Gaurav0/ember-table
that referenced
this pull request
Oct 13, 2015
keep expanded states of grouping rows when sorting partial data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...istered via Handlebars.helper,
layoutName should be used instead,
for more info, please see: emberjs/ember.js#4030.