feat: MK5 shading; fix redundant MK3 trim - #1383
Conversation
MK5 Complex + Backpack Redundant trim removed (MK3 given MK4 trim, gained one variant, maybe it's not lore accurate idk.) Tested visually.
Code Review Roast 🔥Verdict: No Issues Found | Recommendation: Merge Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything. 📊 Overall: Like finding a unicorn in production — I didn't think clean PRs existed anymore, but here we are. Files Reviewed (1 file)
Previous Review Summary (commit 511e6ad)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 511e6ad)Verdict: 1 Critical Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)
🏆 Best part: The sprite plumbing work (shadows, struct structure, muscling armours out of 💀 Worst part: The 📊 Overall: Like a race car with no fuel line — the engine's there, the parts are there, but it's going nowhere fast. Files Reviewed (4 files)
Reviewed by step-3.7-flash · Input: 38.8K · Output: 2.3K · Cached: 244.4K |
There was a problem hiding this comment.
All reported issues were addressed across 19 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Co-authored-by: kilo-code-bot[bot] <240665456+kilo-code-bot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
MK5 Complex + Backpack
Redundant trim removed (MK3 given MK4 trim, it gained one variant, maybe it's not a lore accurate one idk but they were otherwise the same.)
Tested visually.
Summary by cubic
Adds shaded MK5 Complex armour and backpack sprites and wires them into the modular renderer for better depth and lighting. Also cleans up trim selection and moves MK5 setup to culture visuals.
New Features
spr_mk5_complex_shadowandspr_mk5_complex_backpack_shadowand hooked them intoscr_culture_visualsfor “MK5 Heresy”.Refactors
scr_culture_visualsinstead ofscr_ComplexSet.flipinscr_culture_visuals; redundant MK3 trim removed.Written for commit e38e2b7. Summary will update on new commits.