Hero: make the video backdrop fill the block (100%)#12
Merged
Conversation
The <video> element itself carries the .hero-media class, so the descendant selector `.hero-media video` never matched it and the video rendered at its intrinsic size (e.g. 1440x550) instead of filling the hero. Size .hero-video to 100% width/height with object-fit:cover so it fully covers the block. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The authored video (and its poster) is a finished creative with its own headline and CTA, which duplicated and clashed with the overlaid hero text and was muted by the darkening gradient. For the `video` variant, hide the .hero-content overlay and drop the ::after gradient so the media shows edge-to-edge. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #11. The hero video backdrop wasn't filling the block — it rendered at its intrinsic size (e.g. 1440×550) inside a differently-sized hero, leaving gaps.
Cause
The
<video>element itself carries the.hero-mediaclass, so the rule.hero .hero-media video(a descendant selector) never matched it, and the video got no sizing.Fix
Size
.hero-videodirectly towidth/height: 100%withobject-fit: cover, and drop the dead.hero-media videoselector. Verified the video now measures exactly the hero box (1280×600) withobject-fit: cover.Test URLs
(View on desktop ≥900px — per #11 the video is gated to larger viewports; mobile shows the poster.)
🤖 Generated with Claude Code