Nuclear Thermal Rockets & Miscelaneous other bugfixes (2.1.0 Update Candidate) #2108

voidsong-dragonfly · 2021-05-08T15:17:27Z

Nuclear thermal rockets! These use a core made from dilithium and by default hydrogen to make thrust
- Better than advanced engines for efficiency, slightly lower thrust capacity.
- Dilithium core doesn't run out but hydrogen is used
- Core block works very similar to how the old warp core did
Massive internal cleanup for rocket and rocket fluid handling code, because I didn't want to deal with 16 different getters/setters when we could have one parameterized one
Bugfixes, many! Fixes Satellite Builder machine crash on build satellite #2077, [BUG] [1.12.2] ClassCastException crash during Mystcraft world profiling (and potentially other world generation) #2089, [Request] Rockets travel between planets #1798, [Request] Warp Controller on a Rocket ought to require dilithium #1749, Stars always display black hole skybox #1991

Requires LV PR #49 to be merged

- Clean up fuel loader _massively_ - Clean up rocket assembling machine massively - Add in nuclear thermal rockets in place of the warp cores on rockets. - They have a core block which can support many engines, and an engine to themselves - The engines are less powerful than advanced engines, but much more powerful than basic engines - Engines have the same fuel consumption as a single side of a bipropellant engine - Stats are 35 thrust per engine, 1 mB/t ; and 1000 thrust max per core

…ketry#1999 - Fixes display for stars if you _somehow_ warp to one - Fixes stations not being reset, maybe - Fixes star display in selector window if you somehow select one.

- RNG is currently broken for mysterious reasons

… at different atms

…r craters

…uge is now functional

…be done with this mess after this.

… 1.12-2.1.0-fixes

- Fixes Advanced-Rocketry#1082

The changes spill over into the other classes in this commit, since EntityRocket::launch uses them in its logic

- Shades planets to be the right color, fixes Advanced-Rocketry#1094 - Allows per-dimension skybox disabling, fixes Advanced-Rocketry#1531 - Adds comparator support to many blocks - Adds rocket fire so we don't have werid fire problems on launch - Fixes microwave receiver beam effect turning all TESRs yellow

1.12 2.1.0 fixes

src/main/java/zmaster587/advancedRocketry/backwardCompat/WavefrontObject.java

...in/java/zmaster587/advancedRocketry/client/render/multiblocks/RendererMicrowaveReciever.java

src/main/java/zmaster587/advancedRocketry/block/BlockTorchUnlit.java

src/main/java/zmaster587/advancedRocketry/world/ChunkProviderCavePlanet.java

src/main/java/zmaster587/advancedRocketry/world/gen/GenLayerVoronoiExtended.java

src/main/java/zmaster587/advancedRocketry/world/gen/WorldGenAlienTree.java

Co-authored-by: zmaster587 <zmasterfun@gmail.com>

…lfryi/advancedrocketry into feature/nuclearthermalrockets

Solve potential NPE

…lfryi/advancedrocketry into feature/nuclearthermalrockets

Brycey92 · 2021-08-23T16:12:00Z

☆*･゜ﾟ･*\(^O^)/*･゜ﾟ･*☆

voidsong-dragonfly added 18 commits April 2, 2021 11:22

Fix solar array rendering problems

5d8dd49

Fix multiple fueling station bugs and clean up rocket code tremendously

6b1afce

Fix missing return

95405b0

Documentation update!

0a2f9ad

Rocket block damage changes and small fueling station fix

b6d9917

Fix satellite builder

e9aa974

Fix rocket fire placement

4c8a396

Move checking range up one

15bab97

Fix some space elevator errors

90c1a21

Move covered text in space elevator UI

278ba31

Star warp fixes, fixes Advanced-Rocketry#1991 & possibly Advanced-Roc…

4e91def

…ketry#1999 - Fixes display for stars if you _somehow_ warp to one - Fixes stations not being reset, maybe - Fixes star display in selector window if you somehow select one.

Fix players being booted out of ESF because they weren't in a station

1305a5f

Fix double application of multiplier

df96cba

Fix misapplication of (int) because of parenthesis mishap

6bee3dc

Fix incorrect simulation

ac3ecc5

Fix ClassCast problems with fluid blocks

ea9281e

Fix problems with station player return system

93e6841

voidsong-dragonfly added the Exempt ignored by stale bot label May 8, 2021

voidsong-dragonfly added 11 commits May 10, 2021 01:34

Add weights and crater biome weights

7b4705e

First pass of a crater implementation with more randomness

7d60a6e

- RNG is currently broken for mysterious reasons

Finalize crater generation with four sizes of crater that all kick in…

7f62a42

… at different atms

More crater work, fewer overlapped craters and the addition of smalle…

60efd60

…r craters

Add river option, fixes Advanced-Rocketry#1954

5cbade0

i hate inversePartialSquareRadius so much right now but MapGenCraterH…

9cf3308

…uge is now functional

Fixes to small and medium crater generators as well. Hopefully I can …

8503a3c

…be done with this mess after this.

Crater tweaks and volcano random radius additions

619ccfc

Make crater ejecta start slightly larger to make biomes less messy

76358d5

Fix NPE in rocket GUI code, fixes Advanced-Rocketry#2138

f3fadec

More minor crater fixes

e358a6e

Brycey92 and others added 6 commits June 18, 2021 20:36

Merge remote-tracking branch 'sil/feature/nuclearthermalrockets' into…

b4f1b74

… 1.12-2.1.0-fixes

Remove debug log printouts

8ec33e8

Undo casts to WorldProviderPlanet

81379fc

Add in redstone control to simple station controllers

d3029cb

- Fixes Advanced-Rocketry#1082

Improvements and fixes to rocket launch logic

b0fc26c

The changes spill over into the other classes in this commit, since EntityRocket::launch uses them in its logic

voidsong-dragonfly marked this pull request as draft June 20, 2021 23:52

Brycey92 and others added 2 commits June 20, 2021 23:54

Merge branch 'feature/nuclearthermalrockets' into 1.12-2.1.0-fixes

956c8d7

Merge pull request #10 from Brycey92/1.12-2.1.0-fixes

674c0ef

1.12 2.1.0 fixes

voidsong-dragonfly marked this pull request as ready for review June 21, 2021 04:03

voidsong-dragonfly mentioned this pull request Jun 21, 2021

1.16.5 Merge of 2.1.0 Update Candidate #2148

Merged

zmaster587 reviewed Jun 21, 2021

View reviewed changes

voidsong-dragonfly and others added 10 commits June 21, 2021 10:14

Fix one thing from review

41ac6a6

Apply suggestions from code review

882c43e

Co-authored-by: zmaster587 <zmasterfun@gmail.com>

Make microwave receiver render use GL Enum not ints

aff8125

Merge branch 'feature/nuclearthermalrockets' of https://github.com/si…

0a1b751

…lfryi/advancedrocketry into feature/nuclearthermalrockets

Solve potential NPE

19354d1

Merge pull request #12 from Brycey92/1.12-2.1.0-fixes

1050f0d

Solve potential NPE

Allow to compile

48544f0

Merge branch 'feature/nuclearthermalrockets' of https://github.com/si…

48f166f

…lfryi/advancedrocketry into feature/nuclearthermalrockets

One Last Thing

997f81b

Actually fix things without breaking others

2e29a63

voidsong-dragonfly force-pushed the feature/nuclearthermalrockets branch from 0524837 to 2e29a63 Compare July 31, 2021 16:05

voidsong-dragonfly added 4 commits July 31, 2021 16:53

Fix observatory inventory

8fb7da2

Fix model loading error

079bfb7

1.12-specific fluid changes

bc4d132

Why did I move those?

138a22a

voidsong-dragonfly merged commit d92323b into Advanced-Rocketry:1.12 Aug 21, 2021

NielsPilgaard mentioned this pull request Sep 3, 2021

Advanced Rocketry Satellite Builder Crashes on Build EnigmaticaModpacks/Enigmatica2Expert#1953

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Nuclear Thermal Rockets & Miscelaneous other bugfixes (2.1.0 Update Candidate) #2108

Nuclear Thermal Rockets & Miscelaneous other bugfixes (2.1.0 Update Candidate) #2108

Uh oh!

voidsong-dragonfly commented May 8, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Brycey92 commented Aug 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Nuclear Thermal Rockets & Miscelaneous other bugfixes (2.1.0 Update Candidate) #2108

Nuclear Thermal Rockets & Miscelaneous other bugfixes (2.1.0 Update Candidate) #2108

Uh oh!

Conversation

voidsong-dragonfly commented May 8, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Brycey92 commented Aug 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants