Add ability to add affiliate codes to urls #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires you to install the PHP mbstring and intl extensions: sudo apt install php7.0-mbstring php7.0-intl
burnhamrobertp
approved these changes
Aug 17, 2017
Collaborator
burnhamrobertp
left a comment
burnhamrobertp
left a comment
There was a problem hiding this comment.
addAffiliateCode could probably be made more efficient by building a hashmap for any other calls to addAffiliateCode on that same request. Still, looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New affiliate codes can be added via the
app/config/parameters.ymlfile and must follow the format described here https://github.com/AdventureLookup/AdventureLookup/compare/dev...cmfcmf:feature/177-affiliate-code-logic?expand=1#diff-b21427cb85d0a014d5856b811168ad74R33.This will require you to install the PHP mbstring and intl extensions:
closes #177
@JohnnyFlash does this add all the functionality we need?