Fix portrait right-click on ApplicationV2 actor sheets - #230
Open
tasandberg wants to merge 2 commits into
Open
Conversation
tasandberg
marked this pull request as draft
July 6, 2026 23:41
…he element A DocumentSheetV2 root is a <form>; html[0] returns its first form control (not undefined), so html[0] ?? html picked the wrong node and the portrait was never found. Detect jQuery via .jquery instead.
tasandberg
marked this pull request as ready for review
July 7, 2026 00:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #226. Likely also resolves #163 and #191 (v2 / Tidy sheets).
Portrait right-click → Art Select silently stopped working on ApplicationV2 actor sheets (Foundry v14 made these the default):
_modActorSheetis registered onrenderActorSheetonly, but V2 sheets firerenderActorSheetV2— so the handler never runs, with no console error (#226). This registers on both hooks and gates onactorSheet.isEditable(the third hook arg differs across v1/v2).Element normalization: a
DocumentSheetV2root is a<form>, andform[0]returns the form’s first control, notundefined— sohtml[0] ?? htmlpicks the wrong node and the portrait is never found. This detects jQuery via its.jquerymarker instead:html.jquery ? html[0] : html.Tested live in Foundry v14: portrait right-click opens Art Select on dnd5e 5.0.4 v2 sheets, a third-party v2 sheet, and the legacy v1 sheet (unchanged).
#163 (Default vs Legacy 5e) and #191 (Tidy) share the same v2-hook root cause; the portrait path should be resolved, though #163 also mentions prototype-token config (a separate path) and #191 depends on the Tidy portrait carrying a matched selector.