fix(cli): warn instead of failing the gate when the PR comment cannot be posted - #31
Merged
Merged
Conversation
evalgate: support-agentPASS - No regressions detected. Overall score: 94.2% (base) -> 94.2% (head) = 0.0pp
All cases unchanged. tolerance 1.0% - worst case 0.0pp Posted by evalgate - the build fails when your prompt gets dumber. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24
Summary
On fork PRs the github.token is read-only, so the comment POST returns 403. upsertComment threw, the error escaped the top-level handler, and the gate exited 2 even when the comparison found no regression. Fork contributions are exactly where this bites.
Changes
Test plan