Skip to content

ruff is installed and configured but never runs in CI #14

Description

@royalpinto007

Problem

ruff is a declared dev dependency and is configured in pyproject.toml:

dev = ["pytest>=8.3", "pytest-asyncio>=0.24", "httpx>=0.27", "ruff>=0.7"]

[tool.ruff]
line-length = 100

.github/workflows/ci.yml never runs it. The workflow installs .[dev], runs pytest -q, seeds the demo corpus, runs the access-control eval, and uploads the report. No lint step anywhere.

So the linter is installed on every CI run and never used, and the configured line length is enforced by nothing. # noqa: ARG002 appears in app/generate.py, which shows the code was written expecting ruff to run.

Suggested approach

  1. Add a lint step to the test job, after pip install -e ".[dev]" and before the tests so failures surface fast:
    - name: Lint
      run: ruff check .
  2. Add ruff format --check . too, or explicitly decide not to and say so, so contributors know whether formatting is enforced.
  3. Run ruff check . locally first and fix or explicitly configure away whatever it reports. That part is the actual work: expect a handful of findings, and please fix them rather than silencing rules wholesale.
  4. Add the command to CONTRIBUTING.md so contributors can run the same check before pushing.

Done when

  • CI fails on a lint violation.
  • The repository is clean under its own configuration.
  • CONTRIBUTING.md documents the command.

Good first issue: a few lines of YAML plus whatever cleanup ruff asks for. If ruff reports something that looks like a real bug rather than style, open a separate issue for it instead of quietly fixing it in the same PR.


If you want to take this on, comment on the issue to claim it and it will be assigned. Please keep to a maximum of 2 open claims per person at a time so other contributors get a chance.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions