fix: score unresolvable principal refusals correctly - #16
Closed
slegarraga wants to merge 2 commits into
Closed
Conversation
Collaborator
|
Closing this PR. The author is no longer an active contributor on these repositories, so this cannot be carried through review or iterated on. The underlying issue stays open and is available for anyone who wants it. If you were looking at this change, please do open a fresh PR, it is very welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8.
Scores an unresolvable-principal refusal as perfect recall when no documents were expected, and removes the dead
is not Nonefilter frommean_recallso the type and aggregation agree.Adds a pure
mean_recalltest and an async regression test for the unknown-user case.Verified the pure test with
pytest -k mean_recall; the async case requires the project's Postgres fixture.