Skip to content

fix(pagination): announce state to screen readers #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterlemonnn wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −5
Open

fix(pagination): announce state to screen readers #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions components/ui/Pagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ export function Pagination({
}

return (
<div className="mt-6 flex items-center justify-center gap-1 font-mono text-[11px]">
<nav
aria-label="Pagination"
className="mt-6 flex items-center justify-center gap-1 font-mono text-[11px]"
>
{currentPage > 1 ? (
<Link
href={hrefForPage(currentPage - 1)}
Expand All @@ -40,20 +43,29 @@ export function Pagination({
<ArrowLeftIcon size={10} /> Prev
</Link>
) : (
<span className="inline-flex items-center gap-1.5 rounded-sm border border-border-default px-2.5 py-1.5 text-text-tertiary opacity-40">
<span
aria-disabled="true"
className="inline-flex items-center gap-1.5 rounded-sm border border-border-default px-2.5 py-1.5 text-text-tertiary opacity-40"
>
<ArrowLeftIcon size={10} /> Prev
</span>
)}

{pages.map((p, i) =>
p === "…" ? (
<span key={`ellipsis-${i}`} className="px-1 text-text-tertiary">
<span
key={`ellipsis-${i}`}
aria-hidden="true"
className="px-1 text-text-tertiary"
>
…
</span>
) : (
<Link
key={p}
href={hrefForPage(p)}
aria-current={p === currentPage ? "page" : undefined}
aria-label={`Page ${p}`}
className={[
"rounded-sm border px-2.5 py-1.5 transition-colors",
p === currentPage
Expand All @@ -74,10 +86,13 @@ export function Pagination({
Next <ArrowRightIcon size={10} />
</Link>
) : (
<span className="inline-flex items-center gap-1.5 rounded-sm border border-border-default px-2.5 py-1.5 text-text-tertiary opacity-40">
<span
aria-disabled="true"
className="inline-flex items-center gap-1.5 rounded-sm border border-border-default px-2.5 py-1.5 text-text-tertiary opacity-40"
>
Next <ArrowRightIcon size={10} />
</span>
)}
</div>
</nav>
);
}
Loading