fix(broker): bulk-inject Codex PTY tasks#1357
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
📝 WalkthroughWalkthroughPTY injection-rate resolution is now CLI-aware: Codex defaults to bulk injection, while other CLIs retain paced injection. ChangesPTY injection pacing
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Line 8: Update the changelog’s unreleased section heading from “Unreleased -
Patch” to the standard “Unreleased” form, preserving the existing heading level.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a176deea-5a5b-4407-af98-c856673f925c
📒 Files selected for processing (2)
CHANGELOG.mdcrates/broker/src/pty_worker.rs
Summary
Live failure and proof
On sf-mini with Codex 0.144.4, the global 5 ms per-atom default took more than 111 seconds to type the first Relay reminder and never reached the trailing Enter before release. The pending initial task was then dead-lettered as agent_released.
With the equivalent bulk path enabled, a Fleet-targeted Codex worker completed the full CLI flow over Agent Relay:
No claude -p or SSH coordination was used for the proof.
Validation
The broader all-target clippy command still reports three pre-existing test-only warnings in snippets.rs, runtime/api.rs, and runtime/worker_events.rs; the production library clippy gate is clean.