chore: remove unused user-directory package#949
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (2)
✅ Files skipped from review due to trivial changes (3)
📝 WalkthroughWalkthroughThis PR removes the unused ChangesRemove unused user-directory package
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de2169fc37
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,39 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
Update CI package lists after deleting user-directory
Deleting packages/user-directory here leaves stale references in two active workflows I checked: .github/workflows/package-validation.yml still imports @agent-relay/user-directory in its key-import check, and .github/workflows/publish.yml still includes user-directory in publish matrices that run with working-directory: packages/${{ matrix.package }}. After this commit, those jobs will fail with module-not-found or missing-directory errors during PR validation and release publishing.
Useful? React with 👍 / 👎.
Summary
@agent-relay/user-directoryworkspace package.build:user-directoryscript, TypeScript path aliases, Vitest workspace alias, and lockfile entries for that package./data/users/{userId}auth behavior insrc/cli/lib/auth-ssh.ts, where it is already implemented directly.Why
@agent-relay/user-directoryappears to be historical architecture residue. It was originally extracted from daemon-side per-user credential handling, but the daemon package was later removed/migrated and no current product/runtime code imports it.The only active behavior it overlapped with is now inlined in SSH auth:
auth-ssh.tscreates/data/users/{userId}and setsHOMEthere for remote provider auth. Provider credential path metadata also now lives in@agent-relay/config/cli-auth-config, and someuser-directorymappings had drifted from that source of truth, for example Codex and OpenCode credential paths.Exhaustive search found no remaining imports or exported-symbol usage for
@agent-relay/user-directory,UserDirectoryService,getUserDirectoryService,initializeUserEnvironment,getUserEnvironment, or related helpers outside the package being removed.Validation
rgsearch for package name and exported symbols: no remaining referencesnpm run audit:depsnpm run typechecknpm run pack:validatenpm testgit diff --checkNote:
typecheck/testneeded network access because existing package scripts fetch pinned TypeScript/tsx runners throughnpx.