fix(fleet): resolve registered worker node from SDK metadata - #487
Merged
Conversation
Session-Id: 01a0780a-52c0-7140-8c30-1a9b57898d53
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
@coderabbitai review Requested for exact head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A remote worker can be online on its assigned sandbox while Factory reports that it never registered. The Relay SDK carries the worker's placement in
metadata.fleet.node_id, but the fleet adapter reads only top-level node fields. Its registration check consequently compares an absent node with the placement's node name and times out.Resolve the metadata node ID through the node roster before comparing placement. Preserve the existing presence, live-node, capability, and exact-host checks and the 30-second registration deadline. Legacy injected messaging surfaces retain their existing top-level field support.
Validation:
AssertionError: expected false to be true. They use the real published SDK normalizer for snake_case and camelCase inputs and verify rejection for missing/wrong hosts, offline presence, dead nodes, and missing capabilities.No timeout, readiness, breaker, or provisioning guard was widened. Production rollout remains unverified until this change is reviewed, released, and deployed.
CI 34053195710 completed successfully on
7893c706e593cb8ee607b2616d19ed866fcab8e5: all five jobs passed, including the full package suite, packed lifecycle verification (12 checks with a head-bound attestation), and all four infrastructure E2E jobs. Confirmed usinggh run list --branch lane/agent-registration-0906. This draft remains unmerged; no independent review signoff is claimed.