295: deploy/preflight: normalizeTriggerProviderAliases overwrites triggers when an alias collides with its canonical provider#297
Open
agent-relay-code[bot] wants to merge 1 commit into
Conversation
Member
|
PR #297 is ready for human review at commit The alias normalization now appends colliding trigger lists instead of overwriting them, with an end-to-end regression covering Happy to discuss the behavior, validation, or any review questions before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where
packages/deploy/src/preflight.ts—normalizeTriggerProviderAliases()Problem
If an agent declares triggers under both an alias and its canonical name (e.g.
google-mailandgmail), both keys normalize togmailand the second assignment overwrites the first — silently dropping a set of triggers. Assignment should merge the lists.Suggested fix
Edge case (an agent is unlikely to declare both), but the failure is silent — dropped triggers never register and never fire.
Found by CodeRabbit while reviewing the vendored snapshot of this file in AgentWorkforce/skills#87.
Fixes #295