Skip to content

Use TraceSpanDrillInView for Exception when spanEntityId present#4390

Merged
junaway merged 2 commits into
release/v0.100.1from
code/fix-issue-4373-and-run-tests
May 21, 2026
Merged

Use TraceSpanDrillInView for Exception when spanEntityId present#4390
junaway merged 2 commits into
release/v0.100.1from
code/fix-issue-4373-and-run-tests

Conversation

@ashrafchowdury
Copy link
Copy Markdown
Contributor

@ashrafchowdury ashrafchowdury commented May 20, 2026

Motivation

  • Align exception rendering with the existing internals behavior by preferring the drill-in view when a span context is available and avoid showing a standalone fallback panel for exceptions without span context.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment May 21, 2026 7:57am

Request Review

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. Frontend typescript labels May 20, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 10c3a056-cf46-4ab9-af89-22a4c90ca973

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The trace drawer's OverviewTabItem component now conditionally renders exception data using TraceSpanDrillInView when a span entity ID exists. If no span entity ID is available, the exception section renders nothing instead of falling back to a styled accordion panel.

Changes

Exception rendering behavior

Layer / File(s) Summary
Exception panel rendering with drill-in view
web/oss/src/components/SharedDrawers/TraceDrawer/components/TraceContent/components/OverviewTabItem/index.tsx
Exception panel switches to conditionally render TraceSpanDrillInView when spanEntityId is available (passing exception data via spanDataOverride), otherwise renders null instead of the previous AccordionTreePanel fallback.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: using TraceSpanDrillInView for exceptions when spanEntityId is present, which aligns with the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description accurately describes the motivation and intent of the changeset, aligning with the documented objectives to use TraceSpanDrillInView for exceptions when spanEntityId is available.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch code/fix-issue-4373-and-run-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bdeb53fe-f40c-4089-ad1d-3ee68aca0e2e

📥 Commits

Reviewing files that changed from the base of the PR and between 5eef689 and a58d924.

📒 Files selected for processing (1)
  • web/oss/src/components/SharedDrawers/TraceDrawer/components/TraceContent/components/OverviewTabItem/index.tsx

@junaway junaway changed the base branch from main to release/v0.100.1 May 21, 2026 06:09
@junaway junaway merged commit 628c781 into release/v0.100.1 May 21, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex Frontend size:S This PR changes 10-29 lines, ignoring generated files. typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Match exception UI with input and output collapsibles

3 participants