[FE Fix]: Align archived evaluators page layout with active page#4500
Open
ardaerzin wants to merge 1 commit into
Open
[FE Fix]: Align archived evaluators page layout with active page#4500ardaerzin wants to merge 1 commit into
ardaerzin wants to merge 1 commit into
Conversation
Render archived evaluators through the same single PageLayout as the active Evaluators page, with a Back arrow + title in the standard h-11 header row. Drops the ArchivedEntityLayout wrapper, which double-framed the page (extra p-4 + tall stacked Back/title/subtitle header) and pushed the table ~60-70px lower, causing a visible vertical shift when toggling between Evaluators and Archived.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughArchivedEvaluatorsPage is refactored to remove its dependency on ArchivedEntityLayout by directly rendering EvaluatorsRegistry. The main Evaluators component now handles archived-mode UI concerns, including a back navigation button and simplified layout styling. ChangesEvaluators archived page refactoring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dosubot
Bot
added
size:M
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Railway Preview Environment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prevents the layout shift when visiting archived evaluators
Testing
QA follow-up
navigate between evaluators and archived evaluators pages
Checklist
Contributor Resources