chore(frontend): polish the draft-run references fix (doc accuracy and a test guard)#5179
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #5163. A post-merge review found three accuracy gaps, all fixed here.
What was wrong
isDirtymeans the loaded revision carries unsaved edits, from a user edit or a misseddata-committed-revisionrepoint. The README now matches the research.agentRequest.tspointed atservices/oss/src/agent/tracing.py. Theis_draft = revision is Nonelogic actually lives insdks/python/agenta/sdk/agents/tracing.py:165. The comment now points there.application_revisionmust collapse toreferences: null(the empty-object fallback). A new test pins that. The three key-absence assertions were also strengthened fromtoBeUndefined()tonot.toHaveProperty(...), which is the actual wire contract (key absent, not key undefined).Tests
pnpm run test:unitinweb/packages/agenta-playground: 197 passed (196 baseline + 1 new).pnpm lint-fixclean.https://claude.ai/code/session_01CSTSEXSe4DDhoXCFjZpZ5W