Skip to content

chore(runner): bump daytona SDK to @daytona/sdk 0.198 and OTel to 2.x#5362

Merged
mmabrouk merged 1 commit into
mainfrom
vibes/runner-daytona-otel-bump
Jul 17, 2026
Merged

chore(runner): bump daytona SDK to @daytona/sdk 0.198 and OTel to 2.x#5362
mmabrouk merged 1 commit into
mainfrom
vibes/runner-daytona-otel-bump

Conversation

@jp-agenta

Copy link
Copy Markdown
Member

No description provided.

Experimental, off main, runner-only. undici stays 8.3.0 (>=8.5.0 stalls
the ACP write path vs the Daytona proxy - see runner undici pin).

- @daytonaio/sdk -> npm-alias @daytona/sdk@0.198 (package was renamed;
  sandbox-agent@0.4.2 peer-depends on the old name, alias satisfies it
  while shipping the 0.198 client that matches the Daytona platform).
- OTel 1.28/api1.9.0/exporter0.54 -> 2.0.1/api1.9.1/exporter0.220.
- OTel 2.x migration in tracing/otel.ts: new Resource() ->
  resourceFromAttributes(); provider.addSpanProcessor() -> spanProcessors
  constructor arg; ReadableSpan.parentSpanId -> parentSpanContext.spanId.

typecheck clean, 1158/1158 unit tests pass, extension builds.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Jul 17, 2026 2:51pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 134ca806-6d0e-4e7e-8555-ad28dd7647e2

📥 Commits

Reviewing files that changed from the base of the PR and between 327232b and 96e4de0.

⛔ Files ignored due to path filters (1)
  • services/runner/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • services/runner/package.json
  • services/runner/src/tracing/otel.ts

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved trace collection and span ordering for more reliable observability data.
    • Updated tracing compatibility with newer OpenTelemetry and Daytona SDK versions.

Walkthrough

The runner updates Daytona and OpenTelemetry dependencies, constructs resources through resourceFromAttributes, and uses parentSpanContext for trace flushing and parent-first span ordering.

Changes

Runner tracing compatibility

Layer / File(s) Summary
Runner dependency updates
services/runner/package.json
Switches to the newer Daytona SDK alias and upgrades the listed OpenTelemetry packages.
OpenTelemetry API adaptation
services/runner/src/tracing/otel.ts
Uses resourceFromAttributes for service resources and parentSpanContext?.spanId for local-root detection and parent ordering.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided, so there is no meaningful summary to evaluate. Add a short description of the dependency bumps and tracing changes so reviewers can quickly understand the intent.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: bumping the Daytona SDK and OpenTelemetry dependencies in the runner.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vibes/runner-daytona-otel-bump

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

junaway pushed a commit that referenced this pull request Jul 17, 2026
…runner tests

Picks the 3-file dependency bump from vibes/runner-daytona-otel-bump so the installed
2.x OTel deps match the otel.ts API (resourceFromAttributes/spanProcessors/
parentSpanContext). Resolves 39 pre-existing 'Resource is not a constructor' failures.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mmabrouk
mmabrouk marked this pull request as ready for review July 17, 2026 21:29
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. dependencies Dependencies labels Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Railway Preview Environment

Status Destroyed (PR closed)

Updated at 2026-07-17T21:51:06.114Z

@mmabrouk mmabrouk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving per release-runway QA. Live Daytona run on this branch's runner image passed: real Daytona sandbox (SDK 0.198), turn completed finishReason=stop, full invocation span tree present via tracing API (OTel 2.x export verified, exporter 0.220.0 deployed). CI runner image builds green on amd64+arm64; isolated typecheck + 1108 unit tests pass. No Daytona SDK errors.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 17, 2026
@mmabrouk
mmabrouk merged commit 6c0265a into main Jul 17, 2026
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependencies lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants