fix: treat absent harness.kind as pi_core to match runner default - #5674
fix: treat absent harness.kind as pi_core to match runner default#5674waterWang wants to merge 1 commit into
Conversation
When an agent config omits harness.kind, the runner defaults to pi_core but the UI kept harnessValue as null, hiding PiPermissionsControl. Now matches the runner behavior by defaulting to pi_core. Fixes Agenta-AI#5661
|
@waterWang is attempting to deploy a commit to the agenta projects Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
Hi @waterWang, thanks for opening a pull request. 🙏 This PR was automatically closed because it does not yet meet our contribution requirements:
We ask for this so every change is documented and demonstrably tested before review. How to get it reopened See the Contributing guide and Creating your first PR. If you think this was closed in error, leave a comment and a maintainer will take a look. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Disabled knowledge base sources:
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe UI now defaults an absent ChangesHarness selection
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
When an agent config omits
harness.kind, the runner treats the harness aspi_core— all seven Pi built-ins are active and theharness.permissionsallow/ask/deny rules are enforced at runtime. However, the UI keptharnessValueasnullwhenharness.kindwas absent, makingisPiHarnessandhasPiPermissionsevaluate tofalse, which hid the Pi permissions controls.Fix
Changed the default value of
harnessValuefromnulltopi_corewhenharness.kindis not a string, matching the runner's default behavior. This covers both:harness.kind:{harness: {}}— the kind field is undefinedChanges
Fixes #5661