fix(runner): list codex in the /health harnesses payload - #5715
fix(runner): list codex in the /health harnesses payload#5715WahidSaeed wants to merge 2 commits into
Conversation
HARNESS_KINDS in version.ts was not extended when Codex became a harness of its own (its own model catalog, its own CODEX_HOME setup, routed through run-plan.ts like the others). Its only consumer is the /health payload, so nothing was gated on the omission, but a client probing /health concluded Codex was unsupported on this runner. Fixes Agenta-AI#5693
|
@WahidSaeed is attempting to deploy a commit to the agenta projects Team on Vercel. A member of the Team first needs to authorize it. |
|
✅ Thanks @WahidSaeed! This PR now meets the contribution requirements and has been reopened. A maintainer will review it soon. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe runner now includes ChangesCodex harness identity
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi maintainers — this PR was auto-closed for missing a demo, but I think it's a mismatch between the bot and the written policy: CONTRIBUTING.md and the first-pr guide both say a demo is required for UI/UX changes, and that non-visual changes should mark the demo section "not applicable." This change is a one-line addition to a hardcoded string array ( The PR description already includes the concrete before/after of the only observable output (the |
Real captured output: git show of the pre-fix HARNESS_KINDS line, the actual runnerInfo() JSON after the fix, and the actual passing vitest run for version.test.ts. Rendered to PNG via headless Chrome for the PR's required demo image.
Summary
HARNESS_KINDSlist inservices/runner/src/version.tswas not extended when Codex became a harness of its own (its own model catalog, its ownCODEX_HOMEsetup, routed throughrun-plan.tslikepi_core/claude/pi_agenta).runnerInfo().harnesses, surfaced onGET /health— nothing is gated on the list, but a client probing/healthconcludes Codex is unsupported on a runner where it actually works.Fixes #5693
Demo
Backend-only, non-visual change (one string added to a hardcoded array) — the demo below is real captured output: the actual pre-fix line (
git showof the base commit), the actualrunnerInfo()JSON after the fix (run directly against the fixed code), and the actual passing test run forversion.test.ts.Test plan
services/runner/tests/unit/version.test.tsassertingHARNESS_KINDSincludescodexandrunnerInfo().harnessessurfaces it.pnpm vitest run --project unit: 1479/1479 tests pass across 97 files (full runner unit suite, not just the new file).tsc --noEmit: no errors.