Skip to content

fix(frontend): match website favicon.svg artwork to the rest of the icon set - #5743

Merged
mmabrouk merged 1 commit into
mainfrom
code/website-favicon-mismatch-20563e
Aug 5, 2026
Merged

fix(frontend): match website favicon.svg artwork to the rest of the icon set#5743
mmabrouk merged 1 commit into
mainfrom
code/website-favicon-mismatch-20563e

Conversation

@ashrafchowdury

@ashrafchowdury ashrafchowdury commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Problem

The tab icon on the marketing site doesn't match the docs — the mark sits noticeably smaller inside its tile:

marketing site (before) mark at 53.1% × 43.8% of the tile, #0A0A0B background
docs, and every other Agenta surface mark at ~71.5% × 58.6%, #1E1C1D background

Cause

Not the .icowebsite/public/favicon.ico and docs/static/images/favicon.ico are byte-identical (5e12f86a85e98a99634fa48bdc06b291).

The site declares four icons and lists the SVG first:

<link rel="icon" href="/favicon.svg" type="image/svg+xml" />
<link rel="icon" href="/favicon.ico" sizes="32x32" />
...

Every modern browser prefers an SVG favicon when one is offered, so favicon.svg is what actually renders — the .ico is never reached. Docs declare only the .ico (docusaurus.config.ts), which is why they look right.

favicon.svg turned out to be the one asset in the set that wasn't generated from the brand source. It was hand-authored in eb3d176 (on-page SEO) and its transform was eyeballed. Measured mark bounding boxes across the set:

asset mark size tile bg
favicon.ico (= docs) ~71% × 59% #1E1C1D
favicon-32x32.png, favicon.png 68.8% × 56.2% #1E1C1D
favicon-16x16.png 75% × 62.5% #1E1C1D
apple-touch-icon.png 71.1% × 58.9% #1E1C1D
android-chrome-192/512.png ~72% × 58% #1E1C1D
favicon.svg 53.1% × 43.8% #0A0A0B

Fix

Rescale the symbol and correct the tile fill and corner radius in website/public/favicon.svg. One file, two lines — no other asset needed changing.

Verified by rendering the SVG at 512px and comparing the mark's bounding box against android-chrome-512x512.png:

favicon.svg (fixed)          x[73..437] y[105..403]   71.3% W × 58.4% H
android-chrome-512x512.png   x[73..438] y[106..404]   71.5% W × 58.4% H

Preview

Both docs and website
image

The tab icon on agenta.ai did not match the docs (and every other Agenta
surface). Browsers prefer the SVG favicon over the .ico when both are
declared, so favicon.svg — not favicon.ico — is what actually renders,
and it was the only asset in the set drawn from different measurements.

The two .ico files are byte-identical; favicon.svg was hand-authored
separately in the on-page-SEO commit and its transform was eyeballed:
the symbol came out at 53.1% x 43.8% of the tile against ~71.5% x 58.6%
everywhere else, on a #0A0A0B tile instead of #1E1C1D.

Rescale the symbol to scale(2.14) at translate(73 105) and correct the
tile fill and radius, which reproduces the bounding box of
android-chrome-512x512.png to within a pixel:

  favicon.svg  x[73..437] y[105..403]
  canonical    x[73..438] y[106..404]

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. Frontend labels Aug 5, 2026
@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview Aug 5, 2026 1:39pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • website/public/favicon.svg is excluded by !**/*.svg

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7df149c2-de7e-4261-80a9-457dd7516925

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Website preview

Preview URL: https://pr-5743-agenta-website-preview.mahmoud-637.workers.dev

Built from 3e624ad616931534a7f059399ece0e0f3ca06928. This comment updates in place on every push.

@ashrafchowdury

Copy link
Copy Markdown
Contributor Author

I told it not to open a PR until I test it 🤣

@ashrafchowdury

Copy link
Copy Markdown
Contributor Author

Looks good to me

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 5, 2026
@mmabrouk
mmabrouk merged commit ecacb20 into main Aug 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants