feat(frontend): Agent surfaces in @agenta/entity-ui/agent, antd-free - #5771
feat(frontend): Agent surfaces in @agenta/entity-ui/agent, antd-free#5771ardaerzin wants to merge 1 commit into
Conversation
dosubot
Bot
added
size:L
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe package adds reusable agent cards, upcoming trigger displays, tooltip handling, agent-specific lint rules, and public exports for agent UI components and ChangesAgent UI package
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant NextTriggersSection
participant ScheduleQuery
participant SubscriptionQuery
participant TriggerList
NextTriggersSection->>ScheduleQuery: load active schedules
NextTriggersSection->>SubscriptionQuery: load active subscriptions
ScheduleQuery-->>NextTriggersSection: return schedules
SubscriptionQuery-->>NextTriggersSection: return subscriptions
NextTriggersSection->>TriggerList: render filtered and sorted triggers
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (1)
web/packages/agenta-entity-ui/src/agent/AgentCard.tsx (1)
16-17: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueReduce new narrative comments to short constraint comments.
web/packages/agenta-entity-ui/src/agent/AgentCard.tsx#L16-L17: Replace explanatory UI rationale with a short constraint comment. Apply the same change to related new narrative blocks in this component.web/packages/agenta-entity-ui/src/agent/NextTriggersSection.tsx#L29-L36: Replace product rationale with a short constraint comment. Keep only details needed to prevent an implementation error.web/packages/agenta-entity-ui/src/agent/Tip.tsx#L5-L5: Shorten the wrapper description to one line.As per coding guidelines, “Keep in-code comments to at most one short line; use longer comments only for genuinely surprising constraints such as bugs, races, or ordering requirements.”
Source: Coding guidelines
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 11ec04d1-c8f4-4198-9ac3-98037028452e
📒 Files selected for processing (8)
web/packages/agenta-entity-ui/eslint.config.mjsweb/packages/agenta-entity-ui/package.jsonweb/packages/agenta-entity-ui/src/DrillInView/index.tsweb/packages/agenta-entity-ui/src/agent/AgentCard.tsxweb/packages/agenta-entity-ui/src/agent/NextTriggersSection.tsxweb/packages/agenta-entity-ui/src/agent/Tip.tsxweb/packages/agenta-entity-ui/src/agent/index.tsweb/packages/agenta-entity-ui/src/index.ts
76522bf to
1111e32
Compare
468dfc5 to
0d2d3cd
Compare
dosubot
Bot
added
size:XL
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
AgentCard takes a neutral AgentCardData plus callbacks, with the data-connected cells arriving as activity/owner slots; the avatar colour hashes the workflow id, not the name. NextTriggersSection reads trigger data via @agenta/entities/gatewayTrigger and takes display names as an agentNames map. The antd ban is eslint-scoped to src/agent/**. UsageSummary and NewAgentButton stay app-side deliberately: a port would leave an empty shell.
1111e32 to
b000941
Compare
0d2d3cd to
f092df6
Compare
|
Landed in |
2 participants
Context
Fourth lane of the sessions/agents UX stack. The agent card and next-triggers surfaces were built in the oss app for Home, the agents page and the overview. Only the components that survive a headless contract port here;
UsageSummaryandNewAgentButtonstay app-side deliberately (a port would leave an empty shell over app state).Changes
New
@agenta/entity-ui/agentsubpath (the package already exports per-module subpaths, so mobile can import it without touching the antd modules):AgentCardtakes a neutralAgentCardDataplus callbacks. The data-connected cells arrive asactivity/ownerslots. The avatar colour hashes the workflow id, not the name: two agents named "New agent" kept getting the same avatar.NextTriggersSectionreads trigger data via@agenta/entities/gatewayTriggerand takes display names as anagentNamesmap, because the classified agents list is app state.The antd ban is eslint-scoped to
src/agent/**; the rest of the package still uses antd.DrillInViewexports the accordion primitives the overview lane composes.Tests / notes
grep 'from "antd"' src/agentis empty.entities/trigger-helpers(targetsmain):NextTriggersSectionimportstriggerBoundAgentId, so the package build goes green once that PR reaches this stack's base. Everything else on this lane is clean.