Skip to content

fix(sdk): playground auto-refresh after an agent commit (regression from the migration) - #5805

Merged
mmabrouk merged 1 commit into
release/v0.110.0from
fix-committed-revision-refresh
Aug 7, 2026
Merged

fix(sdk): playground auto-refresh after an agent commit (regression from the migration)#5805
mmabrouk merged 1 commit into
release/v0.110.0from
fix-committed-revision-refresh

Conversation

@mmabrouk

@mmabrouk mmabrouk commented Aug 7, 2026

Copy link
Copy Markdown
Member

Context

Mahmoud's live QA found that after an agent commits a config change and the user approves it, the playground no longer switches to the new version automatically. The commit stores correctly; only the refresh signal is missing.

Changes

The SDK's stream adapter projects a successful commit_revision tool output into the data-committed-revision stream part the playground listens for. Its gate required the legacy output's count field. The migrated handler-mode commit answers {"status": "committed", ...} with no count, so the projector silently returned nothing. The gate now accepts either shape, with a comment recording the incident.

Before: no data-committed-revision part in the stream (verified in the reported session: zero occurrences across 108 events).
After: the part streams with correct variantId, revisionId, and version (live-verified with the gate's commit round trip; token match; version bump observed).

Tests

  • New unit test pinning the CURRENT handler shape (it cannot pass without the fix). The old tests only pinned the legacy shape, which is why the suite stayed green through the regression.
  • Full adapter suite: 15 passed.

…mit shape. The stream projector that turns a successful commit_revision tool output into the data-committed-revision part gated on the legacy 'count' field; the migrated handler answers {status: committed, ...} with no count, so the projector silently dropped the part, commits stored fine, and the playground never switched to the new version (live incident, session b024a6b0). The gate now accepts either shape. The suite stayed green through the regression because every fixture pinned the legacy shape; a test now pins the live handler shape. Live-verified: the round trip streams the part with correct ids and the playground signal fires.
@vercel

vercel Bot commented Aug 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview Aug 7, 2026 3:18pm

Request Review

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. Bug Report Something isn't working python Pull requests that update Python code labels Aug 7, 2026
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 73abf5c9-9e36-4328-891e-6e1c09dbca41

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Railway Preview Environment

Status Destroyed (PR closed)

Updated at 2026-08-07T16:39:35.373Z

@mmabrouk
mmabrouk merged commit 18cd21c into release/v0.110.0 Aug 7, 2026
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Report Something isn't working python Pull requests that update Python code size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant