Skip to content

feat(frontend): templates pages join the shared layout - #5846

Merged
mmabrouk merged 2 commits into
release/v0.112.0from
feat/templates-page-layout
Aug 9, 2026
Merged

feat(frontend): templates pages join the shared layout#5846
mmabrouk merged 2 commits into
release/v0.112.0from
feat/templates-page-layout

Conversation

@mmabrouk

@mmabrouk mmabrouk commented Aug 9, 2026

Copy link
Copy Markdown
Member

Mahmoud's templates rework, three parts:

The "opens the first agent" bug

/apps/agent-templates sat where an app id sits in the route, so the app-state parser treated agent-templates AS an app id — putting the whole gallery in an app's context (agent sidebar, bogus useAppId(), and the evaluator templates leaking into view). The path joins RESERVED_APP_COLLECTION_ROUTES beside archived, so the gallery is a proper project-level page now.

Gallery layout

Standard page shape: title at the top in the shared centered column with the page description under it (PageLayout grows an opt-in description prop — pages without one are pixel-unchanged), then two columns on ONE background — no tinted rail, no divider line. Category filters left; search + template grid right.

Detail layout

Top-and-bottom instead of side-by-side: a top bar with the template's name and back to the gallery; body below.

Layout only — template functionality untouched.

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 9, 2026
@vercel

vercel Bot commented Aug 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Error Error Aug 9, 2026 8:56pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: aa7edafd-331d-42e8-baa4-b43d56325257

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mmabrouk
mmabrouk force-pushed the feat/templates-page-layout branch from af1f12a to f1342a5 Compare August 9, 2026 20:15
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 9, 2026
@mmabrouk
mmabrouk changed the base branch from release/v0.112.0 to fix/home-page-scroll August 9, 2026 20:15
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Railway Preview Environment

Status Destroyed (PR closed)

Updated at 2026-08-09T21:22:44.963Z

- Routing: /apps/agent-templates parsed 'agent-templates' as an app id,
  dropping the gallery into the first app's context (the 'opens the first
  agent' bug). It joins the reserved app-collection routes.
- Gallery: standard page shape - title at top in the shared column with a
  description line (PageLayout grows an opt-in description prop), then two
  columns on one background, no tinted rail, no divider: category filters
  left, search + grid right.
- Detail: top-and-bottom - name and back in a top bar, body below, no
  side-by-side layout.
/agent-templates* is a full-height route, so content below the fold was
unreachable at narrow widths. The body scrolls; the back link and the
use action stay pinned.
@mmabrouk
mmabrouk force-pushed the fix/home-page-scroll branch from b9f648f to 1518387 Compare August 9, 2026 20:56
@mmabrouk
mmabrouk force-pushed the feat/templates-page-layout branch from f1342a5 to fd1cb5e Compare August 9, 2026 20:56
@mmabrouk
mmabrouk changed the base branch from fix/home-page-scroll to release/v0.112.0 August 9, 2026 21:22
@mmabrouk
mmabrouk merged commit e689f86 into release/v0.112.0 Aug 9, 2026
67 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend size:L This PR changes 100-499 lines, ignoring generated files. ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant