chore: never track QA gate run artifacts - #5856
Merged
Merged
Conversation
The qa-gate-runs outputs carry per-run probe tokens (QA-CWD-*) that trip secret scanners as generic-api-key hits, and the untracked pile once rode a blanket commit onto a pushed branch (caught by gitleaks, verified to contain no real keys - the tokens are the gate's own synthetic sentinels). Ignoring the directory removes the recurrence path.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dosubot
Bot
added
the
size:XS
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe ChangesQA gate output exclusion
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tonight's secret-scan alarm, resolved: gitleaks flagged 11
generic-api-keyhits in.agents/skills/agent-release-gate/qa-gate-runs/artifacts that briefly rode a blanket commit onto a pushed (then immediately replaced) branch. Verified with the scanner plus a field-level inspection: every hit is the gate's own syntheticQA-CWD-<hex>probe token (cwd_tokenfields and agentreplyechoes), and the files contain zero real key patterns. No credential was exposed; nothing needs rotation.The recurrence path is real though: the run outputs sit untracked in working trees where multiple agents commit, and any blanket add sweeps them in — which then fails every downstream secret scan. One ignore line closes it.