[AGE-4067] docs(agents): Plan custom secret setup and delivery - #6565
[AGE-4067] docs(agents): Plan custom secret setup and delivery#6565mmabrouk wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🤖 The AI agent says: The design is ready for review. The two-milestone split and dependency on #6365 follow the agreed scope. Milestone one's implementation includes the shared credential-handling guidance; this draft PR contains the plan only. Please review 🔸 Decision needed: the plan recommends these narrower implementation choices:
The exact eight-file child diff passes formatting, link/whitespace checks, and gitleaks. Runtime validation is specified in |
Context
Users can save custom secrets and select them for HTTP MCP authentication, but cannot attach an arbitrary saved token to an agent's shell or skills. A setup card also needs to carry the user all the way from creating a secret to continuing the same conversation with the saved binding applied.
Changes
This design splits #5703 / AGE-4067 into two milestones. The first delivers explicitly readable text credentials for internal use, with saved environment bindings, backend resolution, runner injection, and one shared select/create/attach flow for settings and an agent request card. Its implementation includes secret-handling guidance in the shared platform module introduced by #6365. The second adds vault-owned host restrictions and hidden Daytona delivery.
After setup, the card reports a saved binding and revision, never a value. The next run resolves that revision and applies its credentials before the harness continues. The plan covers partial saves, revision conflicts, reloads, cancellation, runtime failure, replacement, and removal.
The simplification pass removes a separate apply endpoint, readiness polling, session-only attachment storage, distributed rollback, and a new runtime lifecycle system. It reuses agent revisions, the vault form, client-tool settlement, and supported reopen/rebuild behavior. The tradeoffs are persistent agent-variant bindings, readable process credentials, and possible process restarts between turns.
This is a design-only child of #6365, based directly on its remote head
ecb28ea14b. No runtime code or prompt text changes in this PR. References #5703; does not close it.How to review
context.mdfor the milestone boundary, thenplan.mdfor the card-to-resume sequence and interrupted setup.contracts.mdfor ownership, permission checks, proposed shapes, and the required shared guidance.simplification.mdfor the removed machinery and tradeoffs, thenqa.mdfor the implementation acceptance checks.research.mdrecords current code entry points.Tests
docs/design/agent-custom-secrets/and scanned with gitleaks.The shared GitButler workspace could not preview updating its stale local parent because of a base-merge conflict. Publication uses the documented temporary-index fallback against #6365's remote head. It does not rewrite the parent PR or apply a new local lane.