[fix] Address CodeRabbit review for milestone 3 by mmabrouk · Pull Request #6580 · Agenta-AI/agenta

mmabrouk · 2026-09-05T15:08:43Z

Context

CodeRabbit identified correctness and reliability gaps in the milestone 3 session-control branch, plus two strict TypeScript test-fixture failures.

Changes

Propagate resumed continuation ownership, reject lost steer bindings, and preserve concurrent heartbeat fences.
Validate open-wire durable events and prevent Redis lease-release failures from masking committed heartbeats.
Repair strict test inputs, back off long-lived approval polling, and accept live-preview attaches mid-execution.

Tests

Core and tracing Alembic legacy and OSS upgrade chains
API sessions: 864 passed
@agenta/chat: 819 passed; focused live-preview: 23 passed; types:check; lint
@agenta/oss: 485 passed, 1 skipped; focused hydration: 12 passed; types:check; lint
@agenta/entities: 1,556 passed
@agenta/mobile: 164 passed
Ruff 0.15.12 format and check

https://claude.ai/code/session_0164kzD6YzYk

Return the execution that owns Send so queued and steered inputs lock and target the resumed continuation instead of the stale stream turn. Claude-Session: https://claude.ai/code/session_0164kzT6ttwpBtzvcDC6YzYk

Validate mapped interaction, message, and tool events at the open-wire boundary so malformed optional strings cannot poison a committed records batch. Claude-Session: https://claude.ai/code/session_0164kzT6ttwpBtzvcDC6YzYk

Return no command when the guarded bind loses its open-state race, and reject the cancel admission instead of pretending the pending input was attached. Claude-Session: https://claude.ai/code/session_0164kzT6ttwpBtzvcDC6YzYk

Treat a failed Redis guard release as a bounded lease delay so it cannot replace the heartbeat result already committed to Postgres. Claude-Session: https://claude.ai/code/session_0164kzT6ttwpBtzvcDC6YzYk

Require the selected stream timestamp to remain unchanged even when the sweep settled that turn as lost, so a concurrent runner heartbeat wins the collapse race. Claude-Session: https://claude.ai/code/session_0164kzT6ttwpBtzvcDC6YzYk

Supply the required hydration reset callback and live-event cursor and event handler so the regression tests remain valid under strict TypeScript. Claude-Session: https://claude.ai/code/session_0164kzT6ttwpBtzvcDC6YzYk

Retain the fast first interaction refresh, then exponentially back off to a sixty-second ceiling while a gate remains open. Claude-Session: https://claude.ai/code/session_0164kzT6ttwpBtzvcDC6YzYk

Treat the first observed frame as the connection baseline and enforce contiguous frame indexes only after that baseline exists. Claude-Session: https://claude.ai/code/session_0164kzT6ttwpBtzvcDC6YzYk

vercel · 2026-09-05T15:08:48Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
agenta-documentation	Ready	Preview	Sep 5, 2026 3:09pm UTC

coderabbitai · 2026-09-05T15:08:52Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

release/.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Team

Run ID: 7fe48a34-a4af-4b2b-8b2a-c90dc8203ccd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

mmabrouk

Agent-generated, low weight.

SHIP

Reviewed the eight commits against the milestone 3 behavior contracts. The fixes preserve queue ordering and flag-off behavior, close the continuation, steer-binding, and heartbeat races, validate durable event ingestion, and add focused regression coverage. The required API and frontend gates pass.

github-actions · 2026-09-05T15:20:13Z

Railway Preview Environment


Preview URL	https://gateway-pr-6580.up.railway.app/w
Project	`agenta-oss-clone-spike`
Image tag	`pr-6580-a1a98c9`
Status	Deployed
Railway logs	Open logs
Workflow logs	View workflow run
Updated at 2026-09-05T15:20:13.199Z

mmabrouk added 8 commits September 5, 2026 17:03

fix(api): propagate resumed continuation execution

808851c

Return the execution that owns Send so queued and steered inputs lock and target the resumed continuation instead of the stale stream turn. Claude-Session: https://claude.ai/code/session_0164kzT6ttwpBtzvcDC6YzYk

fix(api): skip invalid durable event fields

2838cc6

Validate mapped interaction, message, and tool events at the open-wire boundary so malformed optional strings cannot poison a committed records batch. Claude-Session: https://claude.ai/code/session_0164kzT6ttwpBtzvcDC6YzYk

fix(api): reject lost steer command binds

791dc66

Return no command when the guarded bind loses its open-state race, and reject the cancel admission instead of pretending the pending input was attached. Claude-Session: https://claude.ai/code/session_0164kzT6ttwpBtzvcDC6YzYk

fix(api): preserve heartbeat after lease release failure

6e00514

Treat a failed Redis guard release as a bounded lease delay so it cannot replace the heartbeat result already committed to Postgres. Claude-Session: https://claude.ai/code/session_0164kzT6ttwpBtzvcDC6YzYk

test(web): complete session live test inputs

2a05301

Supply the required hydration reset callback and live-event cursor and event handler so the regression tests remain valid under strict TypeScript. Claude-Session: https://claude.ai/code/session_0164kzT6ttwpBtzvcDC6YzYk

fix(frontend): back off approval gate polling

730e9f8

Retain the fast first interaction refresh, then exponentially back off to a sixty-second ceiling while a gate remains open. Claude-Session: https://claude.ai/code/session_0164kzT6ttwpBtzvcDC6YzYk

fix(chat): accept mid-execution live preview attach

3ec93cf

Treat the first observed frame as the connection baseline and enforce contiguous frame indexes only after that baseline exists. Claude-Session: https://claude.ai/code/session_0164kzT6ttwpBtzvcDC6YzYk

vercel Bot deployed to Preview September 5, 2026 15:09 View deployment

mmabrouk commented Sep 5, 2026

View reviewed changes

mmabrouk added the lgtm This PR has been approved by a maintainer label Sep 5, 2026

mmabrouk merged commit 04dba03 into feat/session-approvals-queue Sep 5, 2026
41 checks passed

Navigation Menu

Uh oh!

[fix] Address CodeRabbit review for milestone 3 - #6580

[fix] Address CodeRabbit review for milestone 3#6580
mmabrouk merged 8 commits into
feat/session-approvals-queuefrom
fix/session-approvals-queue-coderabbit

mmabrouk commented Sep 5, 2026

Uh oh!

vercel Bot commented Sep 5, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 5, 2026

Review skipped

Uh oh!

mmabrouk left a comment

Uh oh!

Uh oh!

github-actions Bot commented Sep 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

mmabrouk commented Sep 5, 2026

Context

Changes

Tests

Uh oh!

vercel Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Sep 5, 2026

Review skipped

Uh oh!

mmabrouk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Sep 5, 2026

Railway Preview Environment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Sep 5, 2026 •

edited

Loading