[fix] Enable durable Stop by default - #6584
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🤖 The AI agent says: Independent review passed; corrected both stale environment-example comments. All 18 focused configuration/watchdog tests pass. @coderabbitai review |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughDurable Stop is now enabled by default when ChangesSession stop default
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Sessions now use Durable Stop by default unless explicitly disabled, with the legacy cancellation path retained for false. The updated behavior and watchdog thresholds are covered without an identified current-head merge risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 25.00% which is insufficient. The required threshold is 60.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Railway Preview Environment
|
Enable durable Stop when
AGENTA_SESSIONS_DURABLE_STOPis unset or empty. An explicitfalsestill selects legacy cancellation and its 300-second watchdog threshold; the enabled default uses 90 seconds. Update the OSS/EE example comments to match.Tests
18 focused cancellation-configuration and orphan-watchdog tests pass. Ruff format/check and diff whitespace checks pass. Existing browser QA already exercised the enabled path on both previews; this changes only the fallback configuration and adds no migration.